Small improvements and bug fixes#13
Open
jgabriel98 wants to merge 7 commits intofoxfirecodes:mainfrom
Open
Conversation
jgabriel98
changed the title
Author
|
Ok i've just checked you repo and it seems pretty active. But at least this PR content should provide relevant info on a possible bug (detecting spotify as active player when is actualy not playing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, i was going trought my github repos and found out this.
It seems that long time ago i made some bugfixes to
now-cloking, i've opened some PRs for some but not all...So i'm making this PR to merge to delete my repo fork while at least making my final contribution 😅
It's been 5 years, but i'll try my best to help understanding what the changes are:
playerctl player status, instead of just checking if spotify proccess exists