Skip to content

Include scrolls, wands, spell gems in Anachronism#22344

Open
jfn4th wants to merge 1 commit into
foundryvtt:v14-devfrom
jfn4th:anachronism-spell-consumables
Open

Include scrolls, wands, spell gems in Anachronism#22344
jfn4th wants to merge 1 commit into
foundryvtt:v14-devfrom
jfn4th:anachronism-spell-consumables

Conversation

@jfn4th
Copy link
Copy Markdown
Contributor

@jfn4th jfn4th commented May 16, 2026

Implements #22339

This doesn't touch spell chips, as the equipment items are already included in Anachronism and work the same as they do in the SF2e system, i.e., they do nothing. I saw murmurings in the discord that full spell chip implementation may be waiting on changes to how spells get embedded in items rather than just using the same flow as wands. What's the current plan there? I'd be interested in taking a look at it.

@CarlosFdez
Copy link
Copy Markdown
Collaborator

Try to imitate what we have for languages if possible.

Comment thread build/anachronism/index.ts Outdated
@CarlosFdez
Copy link
Copy Markdown
Collaborator

For context, look at actor/creature/values.ts, at LANGUAGES_BY_RARITY. It is an object key'd by pf2e/sf2e. This would make tree shaking impossible but its a small object so no big deal. But it lets you key by it via SYSTEM_ID in the system and by contentSystem in anachronism. Then you can use recursiveReplaceString from anachronism to replace contentSystem with contentSystem-anachronism. When at all possible we should handle most of the remapping during the anachronism build process rather than adding that complexity to the system itself. This would avoid needing all those helper methods that accept a pack id.

@jfn4th
Copy link
Copy Markdown
Contributor Author

jfn4th commented May 16, 2026

Thank you for the info, I can take another look tomorrow.

@jfn4th jfn4th force-pushed the anachronism-spell-consumables branch from 214971a to fb7d593 Compare May 16, 2026 23:11
@CarlosFdez
Copy link
Copy Markdown
Collaborator

No problem! I already had an idea of how I wanted to do it, but I was preoccupied and putting it off and made the issue to remind myself. But I appreciate someone else handling it, so thank you!

@jfn4th
Copy link
Copy Markdown
Contributor Author

jfn4th commented May 16, 2026

Always happy to help when I have the time, hence my string of recent AppV2/Svelte stuff (I've had a fair amount of Vue experience, so Svelte is fun for me)! I'd like to continue helping out there, especially on finally getting item and actor sheets closer to being ready to move. Like I mentioned in the description, if there are any ideas you guys already have on how we'd like spell chips to be handled I'd be interested in helping out there too.

@CarlosFdez
Copy link
Copy Markdown
Collaborator

I just need to get off my arse with spell chips. I have an idea for allowing spell embedding in general using references rather than our current janky system, I just gotta do it.

I am 70% done with the loot sheet svelte rewrite, which should hopefully open up the rest. Glad to hear you're enjoying svelte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants