Convert NPC Skill Editor to AppV2 and Svelte - #22327
Merged
Merged
Conversation
Collaborator
|
tags busted in dark mode for item-summary should be fixed recently now as of #22311 I recall adding that vite mixin adding errors where it doesn't allow defining |
Collaborator
Author
|
@CarlosFdez I get no such error! |
Collaborator
Author
|
Svelte errors if using |
jfn4th
force-pushed
the
skill-editor-appv2
branch
7 times, most recently
from
May 18, 2026 16:25
8759ed0 to
cfa5ab8
Compare
jfn4th
force-pushed
the
skill-editor-appv2
branch
from
June 8, 2026 23:50
cfa5ab8 to
8f43377
Compare
jfn4th
force-pushed
the
skill-editor-appv2
branch
3 times, most recently
from
June 24, 2026 16:19
c8c6299 to
b104ad3
Compare
jfn4th
force-pushed
the
skill-editor-appv2
branch
from
July 8, 2026 17:29
b104ad3 to
cbcdfa0
Compare
…ss in svelte apps.
jfn4th
force-pushed
the
skill-editor-appv2
branch
from
July 8, 2026 17:39
cbcdfa0 to
da1ff5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes processing of SCSS in svelte files. Up until now, they've been treated as standard CSS even when marked as SCSS.
item-summary.svelteis the only other Svelte app I've found using a SCSS mixin, and its appearance doesn't appear to have changed (its tags are busted in dark mode, but that was the case before this PR and I'll address that separately if no one else gets around to it first).