Skip to content

fix(cast,script): resolve transaction networks more consistently - #16790

Open
mablr wants to merge 1 commit into
masterfrom
mablr/improve-network-consistency
Open

fix(cast,script): resolve transaction networks more consistently#16790
mablr wants to merge 1 commit into
masterfrom
mablr/improve-network-consistency

Conversation

@mablr

@mablr mablr commented Sep 10, 2026

Copy link
Copy Markdown
Member

Transaction commands previously resolved network-specific behavior at different stages and from different sources. This could produce inconsistent handling of explicit network flags, configured chains, RPC-discovered chains, and Tempo sessions, including selecting the wrong signing account or applying incompatible fee settings.

Centralize Cast network resolution with explicit configuration taking precedence over the configured chain and RPC discovery. Reject conflicting Tempo, Ethereum, and Celo selections; resolve Tempo session senders safely; and preserve legacy transaction and named-chain curl behavior.

Apply the same network conflict validation to Forge scripts so transaction execution follows consistent rules across both tools.

This change was developed with AI assistance.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Changelog found

The deterministic check will validate the changed entry.

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mablr
mablr enabled auto-merge (squash) September 10, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants