fix(fmt): retain modifier and constructor comments - #16787
Merged
Conversation
Leave comments before bodies in the main comment stream when a header has no attributes. This prevents the attribute mapper from silently dropping modifier and constructor comments.
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
figtracer
marked this pull request as ready for review
September 10, 2026 19:52
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 10, 2026 19:52
mablr
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge fmtdrops comments before modifier and constructor bodies because the attribute mapper consumes them even when the header has no attributes. Leave those comments for the body printer, with regression coverage for line and block comments and a control case with an attributed modifier. Written with Codex assistance for implementation and regression tests.