fix(fmt): preserve tuple and mapping comments - #16786
Merged
Merged
Conversation
Keep terminating line breaks when formatting omitted tuple elements and mapping keys so comments cannot swallow subsequent Solidity tokens. Cover tuple omissions and named, unnamed, and nested mappings.
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
figtracer
marked this pull request as ready for review
September 10, 2026 19:52
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 10, 2026 19:52
mablr
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line comments in omitted tuple elements and mapping keys can absorb the following Solidity tokens, leaving
forge fmtoutput unparsable. Preserve their terminating line breaks while retaining inline block-comment handling, with regression fixtures for tuple omissions and named, unnamed, and nested mappings. Related to #16649. Written with Codex assistance for implementation and regression tests.