fix(forge): dynamic test linking for try catch with custom return #12050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
0xrusowsky,
DaniPopes,
mattsse,
onbjerg and
zerosnacks
as code owners
DaniPopes
reviewed
Oct 11, 2025
| if *has_ret { | ||
| // try this.addressToCounter1() returns (Counter c) | ||
| try_catch_helpers.insert(name); | ||
| (format!("this.addressTo{name}{id}(", id = contract_id.get()), "}))") |
Member
There was a problem hiding this comment.
should ID be dep.referenced_contract?
Collaborator
Author
There was a problem hiding this comment.
I added the id of the preprocessed contract (test contract) to avoid issues when test inherits another test, for example if CounterTestA is CounterTestB and they both have the addressToCounter function. Adding test contract id will make them unique and avoid collisions
Member
|
rest lgtm |
DaniPopes
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist