Get CommandBox latest stable version on CI runtime#2
Open
michaelborn wants to merge 8 commits intofoundeo:masterfrom
Open
Get CommandBox latest stable version on CI runtime#2michaelborn wants to merge 8 commits intofoundeo:masterfrom
michaelborn wants to merge 8 commits intofoundeo:masterfrom
Conversation
Member
|
Looks like a good idea @michaelborn |
Author
|
Whups - looks like I closed this PR by mistake? Ok, I opened it back up. |
Member
|
@michaelborn thanks - there is another line that needs the |
Author
|
Thanks @pfreitag , done. I'm not sure how to automate the README version table, though... that may be best left to human editors. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses CommandBox's published versioning json file to retrieve the latest stable version number. Once that is done, the CI passes the obtained version through the
docker buildcommand and builds a new minibox image.Once this PR is merged, bumping the commandbox version in Minibox is as easy as firing off a new build.
I recommend squashing when merging, it's not a big change. (Mostly in the GHA workflow)