Skip to content

Fix tests: Use hardcoded constants to fix TypeError #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SehajModi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix tests: Use hardcoded constants to fix TypeError #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88af279
Fix tests: Use hardcoded constants to fix TypeError
SehajModi Dec 15, 2025
58a5d2f
Refactor: Centralize test frequency and fix typos
SehajModi Dec 15, 2025
b96a30e
Fix double file extension
SehajModi Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TEST_FREQUENCY_HZ = 1000000
5 changes: 3 additions & 2 deletions tests/test_spi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
SDI -> SQ1 and LA4
SPI.CS -> LA3
"""

from test_config import TEST_FREQUENCY_HZ
import pytest
import re
from numpy import ndarray
Expand All @@ -30,7 +30,8 @@
CS = "LA3"
SPIMaster._primary_prescaler = PPRE = 0
SPIMaster._secondary_prescaler = SPRE = 0
PWM_FERQUENCY = SPIMaster._frequency * 2 / 3
# Hardcoded to 1MHz for testing
PWM_FERQUENCY = TEST_FREQUENCY_HZ * 2 / 3
MICROSECONDS = 1e-6
RELTOL = 0.05
# Number of expected logic level changes.
Expand Down
4 changes: 3 additions & 1 deletion tests/test_uart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"""

import pytest
from test_config import TEST_FREQUENCY_HZ

from pslab.bus.uart import UART
from pslab.instrument.logic_analyzer import LogicAnalyzer
Expand All @@ -16,7 +17,8 @@
WRITE_DATA = 0x55
TXD2 = "LA1"
RXD2 = "SQ1"
PWM_FERQUENCY = UART._baudrate // 2
# Hardcoded to 1MHz for testing
PWM_FREQUENCY = TEST_FREQUENCY_HZ // 2
MICROSECONDS = 1e-6
RELTOL = 0.05
# Number of expected logic level changes.
Expand Down