Skip to content

Conversation

ishanmitra
Copy link

@ishanmitra ishanmitra commented Sep 4, 2025

While following the build instructions in eventyay-docker, the following warnings appeared:

WARNING  Compiled with 4 warnings                                                                2:17:57 PM

Module Warning (from ./node_modules/eslint-loader/index.js):

/home/ishan/fossasia/eventyay-dev/eventyay-video/webapp/src/App.vue
  194:21  error  Trailing spaces not allowed  no-trailing-spaces1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.


Module Warning (from ./node_modules/eslint-loader/index.js):

/home/ishan/fossasia/eventyay-dev/eventyay-video/webapp/src/views/schedule/index.vue
   63:8  error  '_' is defined but never used  no-unused-vars
  196:2  error  Mixed spaces and tabs          no-mixed-spaces-and-tabs2 problems (2 errors, 0 warnings)


Module Warning (from ./node_modules/eslint-loader/index.js):

/home/ishan/fossasia/eventyay-dev/eventyay-video/webapp/src/views/schedule/sessions/index.vue
  194:18  error    Unexpected space before function parentheses                             space-before-function-paren
  200:15  error    Unexpected space before function parentheses                             space-before-function-paren
  202:47  error    Strings must use singlequote                                             quotes
  204:2   warning  The "watch" property should be above the "created" property on line 200  vue/order-in-components
  291:15  error    Unexpected space before function parentheses                             space-before-function-paren
  292:25  error    Strings must use singlequote                                             quotes

This PR resolves these lint errors.

Summary by Sourcery

Resolve ESLint errors across the webapp by cleaning up imports, standardizing quotes, correcting spacing and indentation, and adjusting component option order

Enhancements:

  • Remove unused imports and variables
  • Standardize string literals to use single quotes instead of backticks
  • Fix spacing issues including trailing spaces, mixed spaces and tabs, and unexpected spaces before function parentheses
  • Reorder Vue component options to satisfy vue/order-in-components rule

Copy link

sourcery-ai bot commented Sep 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR resolves multiple ESLint errors across the webapp by cleaning up whitespace and indentation, enforcing function-parenthesis spacing and quote style, commenting out unused imports, and reordering Vue component options to comply with lint rules.

File-Level Changes

Change Details Files
Removed unnecessary whitespace (trailing spaces, mixed spaces/tabs, extra blank lines)
  • Trimmed trailing spaces in App.vue
  • Replaced mixed tabs and spaces in schedule/index.vue
  • Removed extra blank lines around lifecycle hooks in sessions/index.vue
webapp/src/App.vue
webapp/src/views/schedule/index.vue
webapp/src/views/schedule/sessions/index.vue
Standardized function declaration style by removing space before parentheses
  • Fixed space-before-function-paren for inEventTimezone
  • Adjusted async created hook signature
  • Updated saveTimezone method signature
webapp/src/views/schedule/sessions/index.vue
Unified string quote style to single quotes
  • Replaced backticks with single quotes for localStorage key in sessions component
  • Ensured single quotes in conditional checks in App.vue
webapp/src/views/schedule/sessions/index.vue
webapp/src/App.vue
Addressed unused variables and imports
  • Commented out the unused lodash import in schedule/index.vue
webapp/src/views/schedule/index.vue
Adjusted Vue component option ordering
  • Moved the created hook below the watch block to satisfy vue/order-in-components
webapp/src/views/schedule/sessions/index.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant