-
Notifications
You must be signed in to change notification settings - Fork 45
Fix CNAME gh pages deployment #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #300 by ensuring the CNAME file is included when deploying the documentation to GitHub Pages. The workflow was updated to copy the CNAME file to the correct directory during the build process. A CNAME file was also added. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider renaming the workflow file to
deploy.yml
to align with its purpose. - It might be better to add the CNAME file to the
static
directory and have it copied as part of the build.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove CNAME in the root directory.
fixes #300
Descripton
ref. PR #304
Summary by Sourcery
Fixes an issue where the CNAME file was not being included in the GitHub Pages deployment, preventing the correct association with the custom domain. The deployment workflow is updated to copy the CNAME file into the deploy directory during the build process.
Build:
Deployment: