Added color field in environment model and ui #922

shashank-lol · 2025-11-13T05:52:16Z

PR Description

This pull request implements the color selection feature for an environment from a predefined set of 8 colors. This color will be visible in the Environment pane at the top right .

Implementation Details

Downgraded the freezed dependency to 2.5.7 in all the packages as I wasn't able to change the Environment model to add a color field. Since all the packages had a v3.0.6 freezed dependency but the main project had it to the lower version.
Added a Color parameter in the Env model and created a small dot widget along with the name in the dropdown menu and environments pane.
Updated the test for validation of environments json by adding a color parameter there also.

Screenshots

Related Issues

Closes Adding color support for environments #601

Checklist

I have gone through the contributing guide
I have updated my branch and synced it with project main branch before making this PR
I am using the latest Flutter stable branch (run flutter upgrade and verify)
I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

Yes
No, and this is why: please replace this line with details on why tests have not been included

OS on which you have developed and tested the feature?

Windows
macOS
Linux

ashitaprasad · 2025-11-16T14:37:15Z

@shashank-lol You can refer to the the feedback here - #601 (comment)

Copilot

Pull request overview

This PR adds a color selection feature for environments, allowing users to choose from a predefined palette of 8 colors that are displayed in the environment dropdown and sidebar. The implementation downgrades the freezed dependency from v3.x to v2.5.7 to enable model modifications, adds a color field to the EnvironmentModel, and implements UI components for color display and selection.

Key Changes:

Added color field to EnvironmentModel with custom ColorConverter for JSON serialization
Downgraded freezed and freezed_annotation packages to v2.5.7 across multiple packages
Implemented color picker dialog and visual indicators in the UI

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
packages/apidash_core/lib/models/environment_model.dart	Added Color field with ColorConverter for JSON serialization
packages/apidash_core/lib/models/environment_model.freezed.dart	Generated freezed code for updated EnvironmentModel with color field
packages/apidash_core/lib/models/environment_model.g.dart	Generated JSON serialization code for color field
packages/apidash_core/lib/consts.dart	Added kGlobalColor constant for default environment color
packages/apidash_core/pubspec.yaml	Downgraded freezed packages and openapi_spec version
packages/apidash_core/pubspec_overrides.yaml	Updated dependency path overrides (with Windows-specific separators)
packages/apidash_design_system/lib/widgets/popup_menu.dart	Added colorResolver parameter to display color dots in menu items
packages/apidash_design_system/lib/tokens/colors.dart	Added kEnvColors palette with 8 predefined colors
lib/providers/environment_providers.dart	Updated addEnvironment and updateEnvironment methods to support color parameter
lib/screens/envvar/environments_pane.dart	Added color picker dialog and random color assignment for new environments
lib/widgets/card_sidebar_environment.dart	Added color dot indicator next to environment names
lib/widgets/popup_menu_env.dart	Integrated color display in environment dropdown menu
lib/screens/common_widgets/environment_dropdown.dart	Passed color to environment popup menu
lib/consts.dart	Added editColor option to ItemMenuOption enum
test/models/environment_models.dart	Updated test models to include color field
packages/*/pubspec.yaml	Downgraded freezed dependencies across multiple packages
packages/*/pubspec_overrides.yaml	Updated path overrides with Windows-specific separators
pubspec.lock	Reflected dependency version changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T19:21:49Z

test/models/environment_models.dart

      enabled: false,
    ),
  ],
+  color: kGlobalColor


[nitpick] Missing trailing comma after the color parameter. Adding a trailing comma improves code formatting and makes version control diffs cleaner when adding new parameters.

Suggested change

color: kGlobalColor

color: kGlobalColor,

Copilot · 2025-12-04T19:21:49Z

test/models/environment_models.dart

      enabled: false,
    ),
  ],
+  color: kEnvColors[1]


[nitpick] Missing trailing comma after the color parameter. Adding a trailing comma improves code formatting and makes version control diffs cleaner when adding new parameters.

Suggested change

color: kEnvColors[1]

color: kEnvColors[1],

Copilot · 2025-12-04T19:21:50Z

packages/apidash_core/pubspec_overrides.yaml

+    path: ..\\better_networking
  curl_parser:
-    path: ../curl_parser
+    path: ..\\curl_parser
  genai:
-    path: ../genai
+    path: ..\\genai
  har:
-    path: ../har
+    path: ..\\har
  insomnia_collection:
-    path: ../insomnia_collection
+    path: ..\\insomnia_collection
  postman:
-    path: ../postman
+    path: ..\\postman
  seed:
-    path: ../seed
+    path: ..\\seed


The path separators have been changed from forward slashes (/) to backslashes (\\). This is Windows-specific and will break on Linux and macOS. Dart/Flutter pubspec files should use forward slashes as they work across all platforms. Consider reverting these paths to use forward slashes (e.g., ../better_networking).

Copilot · 2025-12-04T19:21:50Z

packages/apidash_core/lib/models/environment_model.dart

 const kEnvironmentVariableEmptyModel =
-    EnvironmentVariableModel(key: "", value: "");
+EnvironmentVariableModel(key: "", value: "");


Changed from const to non-const unnecessarily. Since kEnvironmentVariableEmptyModel is a constant expression with literal values, it should remain const for compile-time optimization. The removal of const here appears to be unintended.

Copilot · 2025-12-04T19:21:51Z

packages/apidash_design_system/lib/widgets/popup_menu.dart

+  const ADPopupMenu(
+      {super.key,
+      this.value,
+      required this.values,
+      this.onChanged,
+      this.tooltip,
+      this.width,
+      this.isOutlined = false,
+      this.borderColor,
+      this.colorResolver});


[nitpick] Inconsistent indentation and formatting. The constructor parameters should follow a consistent indentation pattern, with each parameter on its own line indented properly. The closing brace and semicolon should also be properly aligned.

Suggested change

const ADPopupMenu(

{super.key,

this.value,

required this.values,

this.onChanged,

this.tooltip,

this.width,

this.isOutlined = false,

this.borderColor,

this.colorResolver});

const ADPopupMenu({

super.key,

this.value,

required this.values,

this.onChanged,

this.tooltip,

this.width,

this.isOutlined = false,

this.borderColor,

this.colorResolver,

});

Copilot · 2025-12-04T19:21:54Z

lib/widgets/popup_menu_env.dart

                    ? "Global"
-                    : getEnvironmentTitle(e.name).clip(30)
+                    : getEnvironmentTitle(e.name).clip(30),
              )) ??


[nitpick] Missing trailing comma after the closing parenthesis on line 35. This would improve formatting consistency. The line should end with a comma after the closing parenthesis of getEnvironmentTitle(e.name).clip(30).

Suggested change

)) ??

,)) ??

Copilot · 2025-12-04T19:21:55Z

packages/apidash_core/lib/models/environment_model.dart

  int get hashCode =>
      environmentId.hashCode ^ variable.hashCode ^ isUnknown.hashCode;
 }
+


[nitpick] The ColorConverter class lacks documentation. Consider adding a doc comment explaining its purpose, such as:

/// Converts between Flutter's [Color] type and an integer representation for JSON serialization. /// Uses ARGB32 format for storage. class ColorConverter implements JsonConverter<Color, int> {

Suggested change

/// Converts between Flutter's [Color] type and an integer representation for JSON serialization.

/// Uses ARGB32 format for storage.

Copilot · 2025-12-04T19:21:55Z

packages/apidash_core/lib/models/environment_model.dart

    required String id,
    @Default("") String name,
    @Default([]) List<EnvironmentVariableModel> values,
+    @ColorConverter() @Default(kGlobalColor) Color color


[nitpick] Missing trailing comma after the color parameter. Adding a trailing comma improves code formatting consistency with Dart style guidelines.

Suggested change

@ColorConverter() @Default(kGlobalColor) Color color

@ColorConverter() @Default(kGlobalColor) Color color,

Copilot · 2025-12-04T19:21:55Z

lib/providers/environment_providers.dart

  void updateEnvironment(
    String id, {
-    String? name,
+    String? name, Color? color,


[nitpick] The parameter formatting is inconsistent. The name and color parameters should be on separate lines or follow a consistent pattern. Currently name, Color? color, appears on one line while other parameters have different formatting.

Suggested change

String? name, Color? color,

String? name,

Color? color,

Copilot · 2025-12-04T19:21:56Z

packages/better_networking/pubspec_overrides.yaml

 dependency_overrides:
  seed:
-    path: ../seed
+    path: ..\\seed


The path separator has been changed from forward slash (/) to backslash (\\). This is Windows-specific and will break on Linux and macOS. Dart/Flutter pubspec files should use forward slashes as they work across all platforms. Consider reverting to ../seed.

Suggested change

path: ..\\seed

path: ../seed

animator · 2025-12-04T19:27:38Z

Review comment has not been addressed and it has also been found that this PR contains various changes that are not required to resolve the issue.

Added color field in environment model and ui

43dca85

animator requested a review from Copilot December 4, 2025 19:14

Copilot started reviewing on behalf of animator December 4, 2025 19:14 View session

Copilot finished reviewing on behalf of animator December 4, 2025 19:18

Copilot AI reviewed Dec 4, 2025

View reviewed changes

animator closed this Dec 4, 2025



	/// Converts between Flutter's [Color] type and an integer representation for JSON serialization.
	/// Uses ARGB32 format for storage.

	@ColorConverter() @Default(kGlobalColor) Color color
	@ColorConverter() @Default(kGlobalColor) Color color,

Added color field in environment model and ui #922

Added color field in environment model and ui #922

Uh oh!

Conversation

shashank-lol commented Nov 13, 2025 • edited by ashitaprasad Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Implementation Details

Screenshots

Related Issues

Checklist

Added/updated tests?

OS on which you have developed and tested the feature?

Uh oh!

ashitaprasad commented Nov 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

animator commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shashank-lol commented Nov 13, 2025 •

edited by ashitaprasad

Loading