Repository navigation
accounts(): the owner's accounts by the exchange's id with their names (0.15.1) - #40
Merged
Merged
Conversation
…sts them, each by the exchange's own id (the text a ledger side's account carries) with the name it gives, default notOffered; Hyperliquid's main wallet then its subAccounts by address with their names; Coinbase's List Portfolios by uuid with their names; Kraken notOffered (institutional-only subaccounts, no listing); CHANGELOG 0.15.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accounts()onExchangeClient, so a move's side can be named: asubAccountTransfer's other side is an address, and the names were resolved privately inside the Hyperliquid client.The shared shape
ExchangeClientAccount { id: String, name: String? }: the exchange's own id, the same text a ledger side'saccountcarries and anaccountparameter takes; the name the exchange gives it,nilwhere it gives none.accounts() async throws -> [ExchangeClientAccount], defaultnotOffered(member: "accounts"), so an existing conformer still compiles. Additive, so a patch version.Hyperliquid
userRole), by its address with no name (Hyperliquid names it by its address alone), then each sub-account ofsubAccounts, by its address lower-cased with its name, in Hyperliquid's order. The read also fills the client's private name table.Coinbase
GET /api/v3/brokerage/portfolios): each portfolio by its uuid with its name, in Coinbase's order. The documentation states the call "retrieves all portfolios of a user", so a deleted one is listed as Coinbase lists it (an older move may name it). The key's own account reads still answer for its portfolio alone.Kraken
notOffered. Subaccounts are "currently only available to institutional clients" and no endpoint lists them.Tests
notOffered.CHANGELOG 0.15.1 rides along.