Skip to content
forked from rhboot/shim-review

About

Reviews of shim

Resources

Readme

Code of conduct

Code of conduct
Activity
Custom properties

Stars

0 stars

Watchers

0 watching

Forks

0 forks
Report repository
BranchesTags
 
 

Repository files navigation

This repo is for review of requests for signing shim. To create a request for review:

  • clone this repo (preferably fork it)
  • edit the template below
  • add the shim.efi to be signed
  • add build logs
  • add any additional binaries/certificates/SHA256 hashes that may be needed
  • commit all of that
  • tag it with a tag of the form "myorg-shim-arch-YYYYMMDD"
  • push it to GitHub
  • file an issue at https://github.com/rhboot/shim-review/issues with a link to your tag
  • approval is ready when the "accepted" label is added to your issue

Note that we really only have experience with using GRUB2 or systemd-boot on Linux, so asking us to endorse anything else for signing is going to require some convincing on your part.

Hint: check the docs directory in this repo for guidance on submission and getting your shim signed.

Here's the template:

What organization or people are asking to have this signed?

Organization name and website:
Fortinet

What's the legal data that proves the organization's genuineness?

The reviewers should be able to easily verify, that your organization is a legal entity, to prevent abuse. Provide the information, which can prove the genuineness with certainty.

Company/tax register entries or equivalent:
(a link to the organization entry in your jurisdiction's register will do)

www.fortinet.com We are a well-known firewall vendor.

The public details of both your organization and the issuer in the EV certificate used for signing .cab files at Microsoft Hardware Dev Center File Signing Services.
(not the CA certificate embedded in your shim binary)

Example:

Issuer: O=MyIssuer, Ltd., CN=MyIssuer EV Code Signing CA
Subject: C=XX, O=MyCompany, Inc., CN=MyCompany, Inc.

Issuer: C=US, O = DigiCert, Inc., CN = DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1
Subject: C=US, S=California, L=Sunnyvale, O = Fortinet, Inc. , CN = Fortinet, Inc., SERIALNUMBER = 3321792

What product or service is this for?

FortiOS

What's the justification that this really does need to be signed for the whole world to be able to boot it?

FortiOS is a linux based Firewall software. We want to support our users to boot FortiOS with secure boot enabled.

Why are you unable to reuse shim from another distro that is already signed?

Reusing another distro's shim would require reusing their grub and kernel as well. We need to build our own kernel, so this would not work.

Who is the primary contact for security updates, etc.?

The security contacts need to be verified before the shim can be accepted. For subsequent requests, contact verification is only necessary if the security contacts or their PGP keys have changed since the last successful verification.

An authorized reviewer will initiate contact verification by sending each security contact a PGP-encrypted email containing random words. You will be asked to post the contents of these mails in your shim-review issue to prove ownership of the email addresses and PGP keys.

  • Name: Colin Wen
  • Position: Senior Director Software Developement
  • Email address: gwen@fortinet.com
  • PGP key fingerprint: 3819 A333 7DC9 07A5 624C EC0B B1A6 BCD1 BB92 76D8

(Key should be signed by the other security contacts, pushed to a keyserver like keyserver.ubuntu.com, and preferably have signatures that are reasonably well known in the Linux community.)

Who is the secondary contact for security updates, etc.?

  • Name: Lingbo Zou
  • Position: Senior Software Engineer
  • Email address: lzou@fortinet.com
  • PGP key fingerprint: 94A4 E88B 4819 C5D8 5262 8513 7712 F4D0 F3CF 3EA7

(Key should be signed by the other security contacts, pushed to a keyserver like keyserver.ubuntu.com, and preferably have signatures that are reasonably well known in the Linux community.)

Were these binaries created from the 16.1 shim release tar?

Please create your shim binaries starting with the 16.1 shim release tar file: https://github.com/rhboot/shim/releases/download/16.1/shim-16.1.tar.bz2

This matches https://github.com/rhboot/shim/releases/tag/16.1 and contains the appropriate gnu-efi source.

Make sure the tarball is correct by verifying your download's checksum (SHA256, SHA512) with the following ones:

46319cd228d8f2c06c744241c0f342412329a7c630436fce7f82cf6936b1d603  shim-16.1.tar.bz2
ca5f80e82f3b80b622028f03ef23105c98ee1b6a25f52a59c823080a3202dd4b9962266489296e99f955eb92e36ce13e0b1d57f688350006bba45f2718f159fb  shim-16.1.tar.bz2

Make sure that you've verified that your build process uses that file as a source of truth (excluding external patches) and its checksum matches. You can also further validate the release by checking the PGP signature: there's a detached signature

The release is signed by the maintainer Peter Jones - his master key has the fingerprint B00B48BC731AA8840FED9FB0EED266B70F4FEF10 and the signing sub-key in the signature here has the fingerprint 02093E0D19DDE0F7DFFBB53C1FD3F540256A1372. A copy of his public key is included here for reference: pjones.asc

Once you're sure that the tarball you are using is correct and authentic, please confirm this here with a simple yes.

A short guide on verifying public keys and signatures should be available in the docs directory.

Yes

URL for a repo that contains the exact code which was built to result in your binary:

Hint: If you attach all the patches and modifications that are being used to your application, you can point to the URL of your application here (https://github.com/YOUR_ORGANIZATION/shim-review).

You can also point to your custom git servers, where the code is hosted.

https://github.com/fortinet/shim-review

What patches are being applied and why:

Mention all the external patches and build process modifications, which are used during your building process, that make your shim binary be the exact one that you posted as part of this application.

No patches are applied

Do you have the NX bit set in your shim? If so, is your entire boot stack NX-compatible and what testing have you done to ensure such compatibility?

See https://techcommunity.microsoft.com/t5/hardware-dev-center/nx-exception-for-shim-community/ba-p/3976522 for more details on the signing of shim without NX bit.

It's not set

What exact implementation of Secure Boot in GRUB2 do you have? (Either Upstream GRUB2 shim_lock verifier or Downstream RHEL/Fedora/Debian/Canonical-like implementation)

Skip this, if you're not using GRUB2.

Upstream GRUB2 shim_lock

Do you have fixes for all the following GRUB2 CVEs applied?

Skip this, if you're not using GRUB2, otherwise make sure these are present and confirm with yes.

All these CVEs are included in grub-2.14.

If shim is loading GRUB2 bootloader, and if these fixes have been applied, is the upstream global SBAT generation in your GRUB2 binary set to 4?

Skip this, if you're not using GRUB2, otherwise do you have an entry in your GRUB2 binary similar to:
grub,4,Free Software Foundation,grub,GRUB_UPSTREAM_VERSION,https://www.gnu.org/software/grub/?

Yes

Were old shims hashes provided to Microsoft for verification and to be added to future DBX updates?

Does your new chain of trust disallow booting old GRUB2 builds affected by the CVEs?

If you had no previous signed shim, say so here. Otherwise a simple yes will do.

Yes

If your boot chain of trust includes a Linux kernel:

Is upstream commit 1957a85b0032a81e6482ca4aab883643b8dae06e "efi: Restrict efivar_ssdt_load when the kernel is locked down" applied?

Is upstream commit 75b0cea7bf307f362057cc778efe89af4c615354 "ACPI: configfs: Disallow loading ACPI tables when locked down" applied?

Is upstream commit eadb2f47a3ced5c64b23b90fd2a3463f63726066 "lockdown: also lock down previous kgdb use" applied?

Hint: upstream kernels should have all these applied, but if you ship your own heavily-modified older kernel version, that is being maintained separately from upstream, this may not be the case.
If you are shipping an older kernel, double-check your sources; maybe you do not have all the patches, but ship a configuration, that does not expose the issue(s).

Yes, all three commits are applied.

How does your signed kernel enforce lockdown when your system runs

with Secure Boot enabled?

Hint: If it does not, we are not likely to sign your shim.

Kernel is compiled with lockdown enforced CONFIG_SECURITY_LOCKDOWN=y.

Do you build your signed kernel with additional local patches? What do they do?

We have some local kernel patches to provide firewall services that are not in standard linux kernel.

Do you use an ephemeral key for signing kernel modules?

If not, please describe how you ensure that one kernel build does not load modules built for another kernel.

Yes, FortiOS uses ephemeral key for signing kernel module.

If you use vendor_db functionality of providing multiple certificates and/or hashes please briefly describe your certificate setup.

If there are allow-listed hashes please provide exact binaries for which hashes are created via file sharing service, available in public with anonymous access for verification.

We do not use vendor_db functionality.

If you are re-using the CA certificate from your last shim binary, you will need to add the hashes of the previous GRUB2 binaries exposed to the CVEs mentioned earlier to vendor_dbx in shim. Please describe your strategy.

This ensures that your new shim+GRUB2 can no longer chainload those older GRUB2 binaries with issues.

If this is your first application or you're using a new CA certificate, please say so here.

Our last shim binary also only loads GRUB2.12 which is not exposed to above CVEs.

Is the Dockerfile in your repository the recipe for reproducing the building of your shim binary?

A reviewer should always be able to run docker build . to get the exact binary you attached in your application.

Hint: Prefer using frozen packages for your toolchain, since an update to GCC, binutils, gnu-efi may result in building a shim binary with a different checksum.

If your shim binaries can't be reproduced using the provided Dockerfile, please explain why that's the case, what the differences would be and what build environment (OS and toolchain) is being used to reproduce this build? In this case please write a detailed guide, how to setup this build environment from scratch.

Dockerfile to reproduce this build is included.

Which files in this repo are the logs for your build?

This should include logs for creating the buildroots, applying patches, doing the build, creating the archives, etc.

build_log.txt.

What changes were made in the distro's secure boot chain since your SHIM was last signed?

For example, signing new kernel's variants, UKI, systemd-boot, new certs, new CA, etc..

Skip this, if this is your first application for having shim signed.

  1. changed shim version from 15.8 to 16.1
  2. changed the embedded certificate.

What is the SHA256 hash of your final shim binary?

3e88d13d467e94a5244f6760652dbbdcf7d5188e58ac0f09ede9b7d4fa67c4ac build-x86_64/shimx64.efi 99bfc7c45fc61655d2dcd966bf43934096c0f5ef3feb3fb6b1f12e9e0542bb3e build-aarch64/shimaa64.efi

How do you manage and protect the keys used in your shim?

Describe the security strategy that is used for key protection. This can range from using hardware tokens like HSMs or Smartcards, air-gapped vaults, physical safes to other good practices.

The keys are stored on HSM with restricted access.

Do you use EV certificates as embedded certificates in the shim?

A yes or no will do. There's no penalty for the latter.

No.

Are you embedding a CA certificate in your shim?

A yes or no will do. There's no penalty for the latter. However, if yes: does that certificate include the X509v3 Basic Constraints to say that it is a CA? See the docs for more guidance about this.

Yes, the certificate includes X509v3 Basic Constraints to say that it is a CA.

Do you add a vendor-specific SBAT entry to the SBAT section in each binary that supports SBAT metadata ( GRUB2, fwupd, fwupdate, systemd-boot, systemd-stub, shim + all child shim binaries )?

Please provide the exact SBAT entries for all binaries you are booting directly through shim.

Hint: The history of SBAT and more information on how it works can be found here. That document is large, so for just some examples check out SBAT.example.md

If you are using a downstream implementation of GRUB2 (e.g. from Fedora or Debian), make sure you have their SBAT entries preserved and that you append your own (don't replace theirs) to simplify revocation.

Remember to post the entries of all the binaries. Apart from your bootloader, you may also be shipping e.g. a firmware updater, which will also have these.

Hint: run objcopy --only-section .sbat -O binary YOUR_EFI_BINARY /dev/stdout to get these entries. Paste them here. Preferably surround each listing with three backticks (```), so they render well.

shim:
sbat,1,SBAT Version,sbat,1,https://github.com/rhboot/shim/blob/main/SBAT.md
shim,4,UEFI shim,shim,1,https://github.com/rhboot/shim
shim.fortios,2,Fortinet,shim,16.1,https://github.com/fortinet/shim-review

grub:
sbat,1,SBAT Version,sbat,1,https://github.com/rhboot/shim/blob/main/SBAT.md
grub,5,Free Software Foundation,grub,2.14,https://www.gnu.org/software/grub/
grub.fortios,2,Fortinet,grub2,2.14,https://www.fortinet.com/

If shim is loading GRUB2 bootloader, which modules are built into your signed GRUB2 image?

Skip this, if you're not using GRUB2.

Hint: this is about those modules that are in the binary itself, not the .mod files in your filesystem.

normal search configfile part_msdos part_gpt fat ext2 linux tpm all_video gfxterm terminal echo

If you are using systemd-boot on arm64 or riscv, is the fix for unverified Devicetree Blob loading included?

We don't use systemd or systemd-boot.

What is the origin and full version number of your bootloader (GRUB2 or systemd-boot or other)?

https://ftp.gnu.org/gnu/grub/grub-2.14.tar.xz

Grub patches

  1. Hide a error message

If your shim launches any other components apart from your bootloader, please provide further details on what is launched.

Hint: The most common case here will be a firmware updater like fwupd.

N/A.

If your GRUB2 or systemd-boot launches any other binaries that are not the Linux kernel in SecureBoot mode, please provide further details on what is launched and how it enforces Secureboot lockdown.

Skip this, if you're not using GRUB2 or systemd-boot.

N/A.

How do the launched components prevent execution of unauthenticated code?

Summarize in one or two sentences, how your secure bootchain works on higher level.

Our shim will only launch our signed GRUB2, which has built-in secure-boot support. GRUB2 will only launch our signed kernel, which is configured to enable lockdown.

Does your shim load any loaders that support loading unsigned kernels (e.g. certain GRUB2 configurations)?

No.

What kernel are you using? Which patches and configuration does it include to enforce Secure Boot?

Our kernel is based on 4.19 with lockdown patches and enforces lockdown.

What contributions have you made to help us review the applications of other applicants?

The reviewing process is meant to be a peer-review effort and the best way to have your application reviewed faster is to help with reviewing others. We are in most cases volunteers working on this venue in our free time, rather than being employed and paid to review the applications during our business hours.

A reasonable timeframe of waiting for a review can reach 2-3 months. Helping us is the best way to shorten this period. The more help we get, the faster and the smoother things will go.

For newcomers, the applications labeled as easy to review are recommended to start the contribution process.

Have not contributed yet, but plan to help.

Add any additional information you think we may need to validate this shim signing application.

No.

About

Reviews of shim

Resources

Readme

Code of conduct

Code of conduct
Activity
Custom properties

Stars

0 stars

Watchers

0 watching

Forks

0 forks
Report repository

Releases

Packages

Contributors

Languages