feat: add 0xProto #107
Open
feat: add 0xProto #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayuhito
reviewed
Sep 26, 2025
There was a problem hiding this comment.
Hi! Really sorry for the late follow up. The current architecture doesn't support this but in the future we will build from source and handle that automatically 🙇
To get this PR merged, you can just stub the bold italic variant with the normal bold one as well. Otherwise, everything else looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Follow-up to 0xType/0xProto#113
This font does not pass the tests because it only has regular, bold and italic variants (there is no bold+italic)
How can we automate this process in the future?
Thanks