Skip to content

Correcting ordinary insert statement for tables with composite primary keys #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Correcting ordinary insert statement for tables with composite primary keys #1468

wants to merge 19 commits into from
+1,228 −551

Conversation

@trueqbit
Copy link
Collaborator

@trueqbit trueqbit commented Nov 27, 2025 •
edited
Loading

Improvements:

  • Objects mapped to tables with composite primary keys are now insertable with an ordinary insert statement: they get inserted with the values of the specified object except for default values.
    • This improvement contains a bug fix for insert statements into tables without rowid where providing values for primary key columns is required (and expected).

Other improvements:

  • Validate base table definition when calling make_table().
    • Specifically this ensures that only one primary key definition is specified.
    • It also means that we can get rid of a runtime error when serializing a get query statement.
  • Validate column definition with respect to auto-increment specifier on a column primary key and the field type.
    • Deprecated types other than 64-bit signed integers - it is clearly stated in the SQLite documentation that auto-increment is only valid for 64-bit signed integer columns and if they are an alias for the implicit rowid column. With SQLite it is a hard error if you try to use a type for a column other than INTEGER.
  • Finally return a 64-bit integer as the last inserted rowid.
    • The worst that can happen is a compiler warning or error depending on the compiler settings because of a narrowing conversion. Users should fix their code.

Fixes

  • Corrected some SQLite version test that enable version-dependent SQLite features.

@trueqbit
Fixed handling composite primary key columns for tables without rowid
10ce490 
The if-condition used for filtering primary key columns must be the same at run-time as at compile-time.
@trueqbit trueqbit linked an issue Nov 27, 2025 that may be closed by this pull request
False NOT NULL constraint failure for table with true composite primary key #1467
Open
@trueqbit
Unit tests for insertions into tables without rowid and compound PKs
0706a7b
@trueqbit
Check up front whether type of range to insert or replace is convertible
64bfce4 
... to the mapped object type, avoiding hard to read error messages later.
@trueqbit
Removed the period after static assert messages, according to the pre…
f1f81fa 
…vailing style
@trueqbit
Unit test for serializing for insert statements involving a primary key
871b134
@trueqbit
Moved cpp guard that enables testing projected range insertions
dac555b
@trueqbit
Same compiler warning options for GNU as for Clang for unit tests
9d93093
@trueqbit
Renamed functions dealing with the table primary key
df79495 
Up until this commit, the functions were referred to as "composite PK functions", although this actually always meant "table PK functions", regardless of whether they were single or composite primary keys defined at the table level.
@trueqbit
Omit only single primary key columns in insert statements
2534b1b
@trueqbit
Renamed auxiliary function testing whether a primary key contains a c…
d359eb4 
…olumn
@trueqbit
Addressed a compiler error that occurred with msvc 141
ebae237
@trueqbit
Validate primary key requirements up front
0de1671
@trueqbit
Improved filter for excluding columns during serialization
aeb72b5 
* Improved understanding through legibility.
@trueqbit
Returned the properly typed last inserted rowid
030d0e7 
For proper type safety `storage_t<>::insert()` needs to return an `sqlite3_int64` instead of an `int`.
This is the best way to correct the problem. Usually, compilers just accept narrowing type conversions, the nicest thing that can happen is a warning message, the worst is an error depending on compiler flags. The programmer has to handle the rest and it is the best thing to do anyway.
@trueqbit
Improved column primary key checks
dcc213f 
* Check column definition up front when making the column.
* Renamed internal traits.
* Removed unit test file `is_column_with_insertable_primary_key.cpp`. It became superfluous during the course of development in the past years. Column constraints are checked elsewhere already, and it is now only a duplicate of `is_primary_key_insertable.cpp`.
@trueqbit
Deprecated types other than 64-bit signed integer for autoincrement PKs
93a23fe 
SQLite documentation clearly states that an auto-incrementable primary key column must be a 64-bit signed integer type.
@trueqbit trueqbit force-pushed the fix/insert-without-rowid branch from 337084c to 93a23fe Compare December 2, 2025 14:15
@trueqbit
Ordinary insert statement skips primary key columns with a default value
9e65e40 
This approach keeps the previous way if all composite primary key columns have a default value, yet still enables inserting records if the table has composite primary key columns with only some or no default values.
@trueqbit
Fixed pre-C++23 if constexpr expression
9eaf678
@trueqbit
Corrected CPP guards for some SQLite features
4791366 
* WITHOUT ROWID is only available since SQLite 3.8.2.
* FTS5: consider that it can be explicitly enabled with `SQLITE_ORM_ENABLE_FTS5`.
* Auxiliary virtual table columns are only available since SQLite 3.24.0.
* Hidden virtual table columns have no version attached.
@trueqbit trueqbit changed the title Fix insertion for tables without rowid Correcting ordinary insert statement for tables with composite primary keys Dec 4, 2025
@trueqbit trueqbit marked this pull request as ready for review December 4, 2025 19:33
@trueqbit trueqbit requested a review from fnc12 December 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fnc12 fnc12 Awaiting requested review from fnc12

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False NOT NULL constraint failure for table with true composite primary key

2 participants

@trueqbit