update update_all_versions command by pingsutw · Pull Request #3219 · flyteorg/flytekit

pingsutw · 2025-04-09T04:10:04Z

Tracking issue

Why are the changes needed?

CI is failing https://github.com/flyteorg/flytekit/actions/runs/14344424181/job/40211181071

What changes were proposed in this pull request?

How was this patch tested?

tested it here https://github.com/flyteorg/flytekit/actions/runs/14349769057/job/40226120233?pr=3219
https://pypi.org/project/flytekitplugins-spark/#history

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR fixes the update_all_versions command in the plugins Makefile by adjusting variable assignment formatting, correcting version string definition and usage, and refactoring grep/sed commands within a shell context. These changes resolve CI failures caused by incorrect command syntax and improve the version updating process.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyte-bot · 2025-04-09T04:10:14Z

Code Review Agent Run #dd580d

Actionable Suggestions - 1

plugins/Makefile - 1
- Incorrect escape sequence in sed pattern · Line 25-25

Review Details

Files reviewed - 1 · Commit Range: 7ce9b62..7ce9b62
- plugins/Makefile
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

codecov · 2025-04-09T04:11:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.66%. Comparing base (e28b0d8) to head (7ce9b62).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e28b0d8) and HEAD (7ce9b62). Click for more details.

HEAD has 12 uploads less than BASE

Flag BASE (e28b0d8) HEAD (7ce9b62)

14 2

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3219       +/-   ##
===========================================
- Coverage   77.35%   46.66%   -30.70%     
===========================================
  Files         214      214               
  Lines       22363    22291       -72     
  Branches     2924     2923        -1     
===========================================
- Hits        17300    10401     -6899     
- Misses       4207    11362     +7155     
+ Partials      856      528      -328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wild-endeavor

but check first?

flyte-bot · 2025-04-09T04:13:00Z

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Bug Fix - Makefile Update for Version Command Fix	- `Makefile` - Adjusted variable formatting and updated sed command delimiters to fix version updating process.

flyte-bot · 2025-04-09T04:13:01Z

plugins/Makefile

 	# it exits with exit code 1 and github actions aborts the build.
 	./run_all_plugins.sh grep "$(PLACEHOLDER)" "$(VERSION_FILE)"
-	./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)
+	./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)\/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)


Incorrect escape sequence in sed pattern

The sed command has an incorrect escape sequence. The backslash before the forward slash creates an incorrect pattern that won't match the placeholder correctly. Remove the backslash before the forward slash.

Code suggestion

Check the AI-generated fix before applying

Suggested change

./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)\/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)

./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)

Code Review Run #dd580d

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyte-bot · 2025-04-09T05:18:22Z

Code Review Agent Run #dc8e16

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 7ce9b62..4e59954
- plugins/Makefile
Files skipped - 2
- .github/workflows/pythonbuild.yml - Reason: Filter setting
- .github/workflows/pythonpublish.yml - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

Signed-off-by: Kevin Su <pingsutw@apache.org>

This reverts commit fe5f551.

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyte-bot · 2025-04-09T06:28:36Z

Code Review Agent Run #6d8558

Actionable Suggestions - 1

plugins/Makefile - 1
- Missing empty string parameter in sed command · Line 24-25

Additional Suggestions - 1

plugins/Makefile - 1
- Unnecessary escaping of quotes in Makefile variable · Line 17-17

Review Details

Files reviewed - 1 · Commit Range: 4e59954..24dd082
- plugins/Makefile
Files skipped - 2
- .github/workflows/pythonbuild.yml - Reason: Filter setting
- .github/workflows/pythonpublish.yml - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

wild-endeavor · 2025-04-09T16:41:21Z

merge when ready. still highly confused as to why this happened. cc @eapolinario. comparing the last known good run and the first bad run, all the gh runner/image/etc versions were identical. sed shouldn't just change behavior.

Current runner version: '2.322.0'
Operating System
  Ubuntu
  [2](https://github.com/flyteorg/flytekit/actions/runs/13864823485/job/38801498941#step:1:2)4.04.2
  LTS
Runner Image
  Image: ubuntu-24.04
  Version: 20250[3](https://github.com/flyteorg/flytekit/actions/runs/13864823485/job/38801498941#step:1:3)09.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu2[4](https://github.com/flyteorg/flytekit/actions/runs/13864823485/job/38801498941#step:1:4)/20250309.1/images/ubuntu/Ubuntu2404-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F202[5](https://github.com/flyteorg/flytekit/actions/runs/13864823485/job/38801498941#step:1:5)0309.1
Runner Image Provisioner
  2.0.422.1

Current runner version: '2.322.0'
Operating System
  Ubuntu
  [2](https://github.com/flyteorg/flytekit/actions/runs/13909886156/job/38921575655#step:1:2)4.04.2
  LTS
Runner Image
  Image: ubuntu-24.04
  Version: 20250[3](https://github.com/flyteorg/flytekit/actions/runs/13909886156/job/38921575655#step:1:3)09.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu2[4](https://github.com/flyteorg/flytekit/actions/runs/13909886156/job/38921575655#step:1:4)/20250309.1/images/ubuntu/Ubuntu2404-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F202[5](https://github.com/flyteorg/flytekit/actions/runs/13909886156/job/38921575655#step:1:5)0309.1

eapolinario · 2025-04-09T20:22:29Z

Comparing the two runs we can see that the issue is that the tag coming from https://github.com/flyteorg/flytekit/blob/master/.github/workflows/pythonpublish.yml#L39-L40 is different now:

It also repros locally:

~/repos/flytekit3/plugins/flytekit-airflow master ?1
❯ sed -i "s/"__version__\ =\ \"0.0.0+develop\""/__version__ = \"refs/tags/1.16.0b0\"/g" "setup.py"
sed: -e expression #1, char 53: unknown option to `s'

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>

update update_all_versions command

7ce9b62

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw requested review from Future-Outlier, cosmicBboy, davidmirror-ops, eapolinario, kumare3, samhita-alla, thomasjpfan and wild-endeavor as code owners April 9, 2025 04:10

wild-endeavor previously approved these changes Apr 9, 2025

View reviewed changes

flyte-bot reviewed Apr 9, 2025

View reviewed changes

test ci

52ff3f6

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw dismissed wild-endeavor’s stale review via 52ff3f6 April 9, 2025 04:15

pingsutw added 11 commits April 9, 2025 12:17

test

8042211

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

a78645f

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

793d3ad

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

51158b1

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

25db60e

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

0cdeb64

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

f14eb75

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

297fbd6

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

6e1779c

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

95884e3

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

4e59954

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw added 2 commits April 9, 2025 13:21

test

033449f

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

27465ba

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw added 2 commits April 9, 2025 13:31

test ci

7f995b5

Signed-off-by: Kevin Su <pingsutw@apache.org>

test

fe5f551

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw requested a review from fg91 as a code owner April 9, 2025 05:33

pingsutw added 5 commits April 9, 2025 13:33

Revert "test"

b4fa544

This reverts commit fe5f551.

test

3c843cb

Signed-off-by: Kevin Su <pingsutw@apache.org>

update

553abf7

Signed-off-by: Kevin Su <pingsutw@apache.org>

nit

4562e3a

Signed-off-by: Kevin Su <pingsutw@apache.org>

lint

24dd082

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyteorg deleted a comment from flyte-bot Apr 9, 2025

wild-endeavor approved these changes Apr 9, 2025

View reviewed changes

pingsutw merged commit 2665630 into master Apr 10, 2025
114 checks passed

Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025

update update_all_versions command (flyteorg#3219)

81933f2

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

update update_all_versions command#3219

update update_all_versions command#3219
pingsutw merged 22 commits intomasterfrom
fix-sed

pingsutw commented Apr 9, 2025 •

edited by flyte-bot

Loading

Uh oh!

flyte-bot commented Apr 9, 2025 •

edited

Loading

Code Review Agent Run #dd580d

Uh oh!

codecov bot commented Apr 9, 2025

Uh oh!

wild-endeavor left a comment

Uh oh!

flyte-bot commented Apr 9, 2025 •

edited

Loading

Changelist by Bito

Uh oh!

flyte-bot Apr 9, 2025

Uh oh!

flyte-bot commented Apr 9, 2025 •

edited

Loading

Code Review Agent Run #dc8e16

Uh oh!

flyte-bot commented Apr 9, 2025 •

edited

Loading

Code Review Agent Run #6d8558

Uh oh!

wild-endeavor commented Apr 9, 2025

Uh oh!

eapolinario commented Apr 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)\/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)
	./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)

Comments

Conversation

pingsutw commented Apr 9, 2025 • edited by flyte-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

Summary by Bito

Uh oh!

flyte-bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #dd580d

Uh oh!

codecov bot commented Apr 9, 2025

Codecov Report

Uh oh!

wild-endeavor left a comment

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist by Bito

Uh oh!

flyte-bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #dc8e16

Uh oh!

flyte-bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #6d8558

Uh oh!

wild-endeavor commented Apr 9, 2025

Uh oh!

eapolinario commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pingsutw commented Apr 9, 2025 •

edited by flyte-bot

Loading

flyte-bot commented Apr 9, 2025 •

edited

Loading

flyte-bot commented Apr 9, 2025 •

edited

Loading

flyte-bot commented Apr 9, 2025 •

edited

Loading

flyte-bot commented Apr 9, 2025 •

edited

Loading

eapolinario commented Apr 9, 2025 •

edited

Loading