don't reuse parent wf state for array node subnodes

[pvditt]

Why are the changes needed?

fixes problem described in #6809
(array node subnodes are incrementing parent wf parallelism despite parallelism behavior opting to not increment wf parallelism)

What changes were proposed in this pull request?

re-initialize the sub-node's control flow to not share/update the parent wf state

How was this patch tested?

• added unit test
• ran locally
• (this change was running in union's flyte v1 fork for a long time)

Labels

Please add one or more of the following labels to categorize your PR:

• added: For new features.
• changed: For changes in existing functionality.
• deprecated: For soon-to-be-removed features.
• removed: For features being removed.
• fixed: For any bug fixed.
• security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.96%. Comparing base (b5f898c) to head (7bb8cab).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6929      +/-   ##
==========================================
- Coverage   56.96%   56.96%   -0.01%     
==========================================
  Files         929      929              
  Lines       58156    58158       +2     
==========================================
- Hits        33130    33127       -3     
- Misses      21984    21989       +5     
  Partials     3042     3042              

Flag	Coverage Δ
unittests-datacatalog	53.51% <ø> (ø)
unittests-flyteadmin	53.10% <ø> (-0.04%)	⬇️
unittests-flytecopilot	43.06% <ø> (ø)
unittests-flytectl	64.02% <ø> (ø)
unittests-flyteidl	75.71% <ø> (ø)
unittests-flyteplugins	60.14% <ø> (ø)
unittests-flytepropeller	53.65% <100.00%> (+<0.01%)	⬆️
unittests-flytestdlib	63.29% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fg91]

I ran propeller with this change and can confirm that it fixes the minimal reproducing example I reported here.

The solution also makes sense to me.

Thank you for fixing @pvditt 🙇

(Can you please fix the linting error?)