Open
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
kumare3
reviewed
Feb 20, 2026
| Informer { | ||
| client, | ||
| run_id, | ||
| action_cache: Arc::new(RwLock::new(HashMap::new())), |
machichima
reviewed
Feb 23, 2026
Comment on lines
+38
to
+58
| # Extract flyteidl2 version from root pyproject.toml | ||
| ROOT_VER=$(grep 'flyteidl2==' pyproject.toml | head -1 | sed 's/.*flyteidl2==\([^"]*\).*/\1/') | ||
| echo "Root pyproject.toml: flyteidl2==$ROOT_VER" | ||
|
|
||
| # Extract flyteidl2 version from rs_controller/Cargo.toml | ||
| CARGO_VER=$(grep 'flyteidl2' rs_controller/Cargo.toml | grep -v '^#' | sed 's/.*"=\(.*\)".*/\1/') | ||
| echo "rs_controller/Cargo.toml: flyteidl2=$CARGO_VER" | ||
|
|
||
| # Extract flyteidl2 version from rs_controller/pyproject.toml | ||
| RS_VER=$(grep 'flyteidl2==' rs_controller/pyproject.toml | head -1 | sed 's/.*flyteidl2==\([^"]*\).*/\1/') | ||
| echo "rs_controller/pyproject.toml: flyteidl2==$RS_VER" | ||
|
|
||
| # Compare all three | ||
| if [ "$ROOT_VER" != "$CARGO_VER" ] || [ "$ROOT_VER" != "$RS_VER" ]; then | ||
| echo "ERROR: flyteidl2 versions do not match!" | ||
| echo " pyproject.toml: $ROOT_VER" | ||
| echo " rs_controller/Cargo.toml: $CARGO_VER" | ||
| echo " rs_controller/pyproject.toml: $RS_VER" | ||
| exit 1 | ||
| fi | ||
| echo "All flyteidl2 versions match: $ROOT_VER" |
Member
There was a problem hiding this comment.
nit: I think this check can break if the format in pyproject.toml/Cargo.toml changed (e.g. flyteidl2==1.0.0 to "flyteidl2==1.0.0")? Maybe it's better to parse with python tomllib?
Member
There was a problem hiding this comment.
The changes here seem to be for local testing? Should we remove it here?
Comment on lines
+229
to
+234
| pub async fn remove_action(&self, action_name: &str) -> Option<Action> { | ||
| let mut cache = self.action_cache.write().await; | ||
| let dropped_action = cache.remove(action_name); | ||
| self.completion_events.write().await.remove(action_name); | ||
| debug!("Removed action and completion event for {}", action_name); | ||
| dropped_action |
Member
There was a problem hiding this comment.
It would be better to release the lock before acquiring the other, like so:
pub async fn remove_action(&self, action_name: &str) -> Option<Action> {
let dropped_action = {
let mut cache = self.action_cache.write().await;
cache.remove(action_name)
};
{
let mut events = self.completion_events.write().await;
events.remove(action_name);
}
debug!("Removed action and completion event for {}", action_name);
dropped_action
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_native_roots()to pick up root certs).