adding progress bar for asyncio operations#674
Open
debasisdwivedy wants to merge 1 commit intoflyteorg:mainfrom
Open
adding progress bar for asyncio operations#674debasisdwivedy wants to merge 1 commit intoflyteorg:mainfrom
debasisdwivedy wants to merge 1 commit intoflyteorg:mainfrom
Conversation
Signed-off-by: debasisdwivedy <dwivedy.debasis@gmail.com>
Contributor
|
Thank you, but this is a hard one to take as it introduces new dependencies and not sure if plays well, with runtime and cli |
kumare3
reviewed
Feb 15, 2026
| "aiolimiter>=1.2.1", | ||
| "flyteidl2==2.0.2", | ||
| "packaging", | ||
| "tqdm>=4.67.3", |
Contributor
There was a problem hiding this comment.
Really prefer if you use rich progress if at all. No new dependencies please
| uploaded_files.append(_upload_single_file(cfg, file, verify=verify, basedir=prefix)) | ||
|
|
||
| urls = await asyncio.gather(*uploaded_files) | ||
| urls = await tqdm.gather(*uploaded_files,desc=f"Uploading files to {dir_path}") |
Contributor
There was a problem hiding this comment.
Rendering this becomes a big challenge - we need to think about the rendering and overhead architecture of runtime vs cli
Contributor
Author
|
Agreed. Let's keep this PR open till we figure out the best way todo it. We can also look into rich-progress bar. I have not used it though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Adding progress bars using
tqdmpackage for asynchronous operations