Adding common "reason" constants #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdasson
requested review from
darkowlzz,
hiddeco and
stefanprodan
as code owners
darkowlzz
reviewed
Jan 26, 2024
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
Left a few minor suggestions. Otherwise, the new constants look good to me.
gdasson
force-pushed
the
main
branch
2 times, most recently
from
a44d758 to
81fee37
Compare
Contributor
Author
|
@darkowlzz : Thanks for the review. I have incorporated your review comments: rebased, fixed and squashed my commits as well. Please review again and let me know if more updates are required. thx. |
Contributor
Author
|
@stefanprodan , @hiddeco : Could you please review this PR? Its pending your review and approval. Thanks. |
darkowlzz
reviewed
Mar 7, 2024
Member
|
@gdasson please rebase with main and force push. |
Signed-off-by: Gaurav Dasson <[email protected]>
Contributor
Author
|
@stefanprodan: Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "reason" constants to the pkg repo as suggested in this PR: fluxcd/notification-controller#701
This will be followed by a PR in kustomize controller to refer to these constants from common pkg repo here and updates to the above mentioned PR to do the same.