Skip to content

[file_selector] Update Linux example for deprecations #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

[file_selector] Update Linux example for deprecations #10542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/file_selector/file_selector_linux/example/lib/get_directory_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ class GetDirectoryPage extends StatelessWidget {
Future<void> _getDirectoryPath(BuildContext context) async {
const confirmButtonText = 'Choose';
final String? directoryPath = await FileSelectorPlatform.instance
.getDirectoryPath(confirmButtonText: confirmButtonText);
.getDirectoryPathWithOptions(
const FileDialogOptions(confirmButtonText: confirmButtonText),
);
Comment on lines 15 to +19
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness, you can inline the confirmButtonText constant directly into the FileDialogOptions constructor. This avoids creating a local variable that is only used once, which is a general recommendation in the Dart style guide.1

Suggested change
const confirmButtonText = 'Choose';
final String? directoryPath = await FileSelectorPlatform.instance
.getDirectoryPath(confirmButtonText: confirmButtonText);
.getDirectoryPathWithOptions(
const FileDialogOptions(confirmButtonText: confirmButtonText),
);
final String? directoryPath = await FileSelectorPlatform.instance
.getDirectoryPathWithOptions(
const FileDialogOptions(confirmButtonText: 'Choose'),
);

Style Guide References

Footnotes

  1. The repository style guide states that code should follow the relevant style guides for each language. For Dart, this includes following 'Effective Dart' guidelines, which recommend avoiding local variables that are used only once. ↩

if (directoryPath == null) {
// Operation was canceled by the user.
return;
Expand Down
4 changes: 3 additions & 1 deletion packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ class GetMultipleDirectoriesPage extends StatelessWidget {
Future<void> _getDirectoryPaths(BuildContext context) async {
const confirmButtonText = 'Choose';
final List<String> directoryPaths = await FileSelectorPlatform.instance
.getDirectoryPaths(confirmButtonText: confirmButtonText);
.getDirectoryPathsWithOptions(
const FileDialogOptions(confirmButtonText: confirmButtonText),
);
Comment on lines 15 to +19
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness, you can inline the confirmButtonText constant directly into the FileDialogOptions constructor. This avoids creating a local variable that is only used once, which is a general recommendation in the Dart style guide.1

Suggested change
const confirmButtonText = 'Choose';
final List<String> directoryPaths = await FileSelectorPlatform.instance
.getDirectoryPaths(confirmButtonText: confirmButtonText);
.getDirectoryPathsWithOptions(
const FileDialogOptions(confirmButtonText: confirmButtonText),
);
final List<String> directoryPaths = await FileSelectorPlatform.instance
.getDirectoryPathsWithOptions(
const FileDialogOptions(confirmButtonText: 'Choose'),
);

Style Guide References

Footnotes

  1. The repository style guide states that code should follow the relevant style guides for each language. For Dart, this includes following 'Effective Dart' guidelines, which recommend avoiding local variables that are used only once. ↩

if (directoryPaths.isEmpty) {
// Operation was canceled by the user.
return;
Expand Down