Add Versioning to Gradle 9 Deprecation Change #10187
Conversation
jesswrd
requested review from
bparrishMines,
ash2moon,
gmackall,
camsim99,
mboetger and
reidbaker
as code owners
github-actions
bot
added
p: camera
p: espresso
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates multiple packages to resolve Gradle 9 deprecations. The changes involve bumping package versions in pubspec.yaml files and adding corresponding entries to CHANGELOG.md files.
My review found several issues with the CHANGELOG.md files:
- In some cases, a new version is inserted into the middle of the changelog history, which is incorrect. New versions should always be at the top.
- In other cases, the changelog entry for the new version is swapped with an older one.
I've left specific comments on the affected files with suggestions for correction.
Additionally, it seems that for some packages where the CHANGELOG.md was updated, the corresponding pubspec.yaml file was not included in the pull request. Please ensure that for every updated changelog, the pubspec.yaml version is also bumped and included in the PR.
| ## 0.10.10+9 | ||
|
|
||
| * Restores compileSdk version to flutter.compileSdkVersion. | ||
|
|
||
| ## 0.10.10+8 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change 'Resolves Gradle 9 deprecations' should be under the new version 0.10.10+9.
| ## 0.10.10+9 | |
| * Restores compileSdk version to flutter.compileSdkVersion. | |
| ## 0.10.10+8 | |
| * Resolves Gradle 9 deprecations. | |
| ## 0.10.10+9 | |
| * Resolves Gradle 9 deprecations. | |
| ## 0.10.10+8 | |
| * Restores compileSdk version to flutter.compileSdkVersion. |
| ## 0.4.0+17 | ||
|
|
||
| * Bumps `com.google.guava:guava` from `33.4.8-android` to `33.5.0-android`. | ||
|
|
||
| ## 0.4.0+15 | ||
| ## 0.4.0+16 | ||
|
|
||
| * Updates Java compatibility version to 17. | ||
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | ||
|
|
||
| ## 0.4.0+15 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change, 'Resolves Gradle 9 deprecations', should be under the new version 0.4.0+17. The previous versions' entries should be preserved correctly.
| ## 0.4.0+17 | |
| * Bumps `com.google.guava:guava` from `33.4.8-android` to `33.5.0-android`. | |
| ## 0.4.0+15 | |
| ## 0.4.0+16 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | |
| ## 0.4.0+15 | |
| * Resolves Gradle 9 deprecations. | |
| ## 0.4.0+17 | |
| * Resolves Gradle 9 deprecations. | |
| ## 0.4.0+16 | |
| * Bumps `com.google.guava:guava` from `33.4.8-android` to `33.5.0-android`. | |
| ## 0.4.0+15 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. |
| ## 0.5.1+18 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
This new version 0.5.1+18 is older than the current latest version 0.5.2. The new change should be under a new, higher version number (e.g., 0.5.3 or 0.5.2+1) at the top of the file.
| ## 0.2.7+1 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
This new version 0.2.7+1 is older than the current latest version 0.2.8. The new change should be under a new, higher version number (e.g., 0.2.9 or 0.2.8+1) at the top of the file.
| ## 1.0.25 | ||
|
|
||
| * Updates Java compatibility version to 17. | ||
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | ||
|
|
||
| ## 1.0.24 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change 'Resolves Gradle 9 deprecations' should be under the new version 1.0.25.
| ## 1.0.25 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | |
| ## 1.0.24 | |
| * Resolves Gradle 9 deprecations. | |
| ## 1.0.25 | |
| * Resolves Gradle 9 deprecations. | |
| ## 1.0.24 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. |
| ## 2.4.15 | ||
|
|
||
| * Updates Java compatibility version to 17. | ||
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | ||
|
|
||
| ## 2.4.14 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change 'Resolves Gradle 9 deprecations' should be under the new version 2.4.15.
| ## 2.4.15 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | |
| ## 2.4.14 | |
| * Resolves Gradle 9 deprecations. | |
| ## 2.4.15 | |
| * Resolves Gradle 9 deprecations. | |
| ## 2.4.14 | |
| * Updates Java compatibility version to 17. | |
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. |
| ## 6.3.24 | ||
|
|
||
| * Updates Java compatibility version to 17. | ||
|
|
||
| ## 6.3.23 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change 'Resolves Gradle 9 deprecations' should be under the new version 6.3.24.
| ## 6.3.24 | |
| * Updates Java compatibility version to 17. | |
| ## 6.3.23 | |
| * Resolves Gradle 9 deprecations. | |
| ## 6.3.24 | |
| * Resolves Gradle 9 deprecations. | |
| ## 6.3.23 | |
| * Updates Java compatibility version to 17. |
| ## 4.10.5 | ||
|
|
||
| * Adds a README section about enabling geolocation. | ||
|
|
||
| ## 4.10.3 | ||
| ## 4.10.4 | ||
|
|
||
| * Updates Java compatibility version to 17. | ||
|
|
||
| ## 4.10.3 | ||
|
|
||
| * Resolves Gradle 9 deprecations. |
There was a problem hiding this comment.
The changelog entries appear to be misaligned. The new change 'Resolves Gradle 9 deprecations' should be under the new version 4.10.5.
| ## 4.10.5 | |
| * Adds a README section about enabling geolocation. | |
| ## 4.10.3 | |
| ## 4.10.4 | |
| * Updates Java compatibility version to 17. | |
| ## 4.10.3 | |
| * Resolves Gradle 9 deprecations. | |
| ## 4.10.5 | |
| * Resolves Gradle 9 deprecations. | |
| ## 4.10.4 | |
| * Adds a README section about enabling geolocation. | |
| ## 4.10.3 | |
| * Updates Java compatibility version to 17. |
When Flutter clients use published plugins that depend on other outdated/older plugins with an app using Gradle 9, they will be using outdated Gradle 9 deprecated patterns (in
build.gradle). To ensure usage of resolved deprecated build.gradle files, Flutter clients can specify the pub version in this PR.Should have included versioning and changelog in this PR: #10016
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3