in_tail: Add descriptions for encoding parameters on in tail - #1870
Conversation
d8ef3d9 to
331b498
Compare
|
@fluent/chronosphere-tech-writers could you please review this one? Thanks in advance! |
alexakreizinger
left a comment
There was a problem hiding this comment.
suggested some changes for style, but adding my approval based on those 😁 happy to take another look if you need to make changes to any of my changes, too. (also I want to make sure any changes stay in sync with #1471!)
e206b78 to
2b5890b
Compare
|
@cosmo0920 if you can resolve the conflicts, I can get this merged together with #1471 |
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Also I added the reason why we need to support these parameters and how to use them. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
2b5890b to
e54556f
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
markdownlint
[markdownlint] reported by reviewdog 🐶
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
fluent-bit-docs/pipeline/inputs/tail.md
Line 529 in e54556f
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
a699d44 to
37e837d
Compare
|
@cosmo0920 this is still in conflict... did get #1471 merged this morning my time, can you revisit? |
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
|
@esmerel good morning! The only thing holding back merging this PR are a couple of Vale checks showing the following errors: Raw Output: Raw Output: Can you take a look at this? |
This should correct the severe vale errors and most of the suggestions, as well as matching current style. Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
|
||
| - Legacy Windows systems with applications that use traditional code pages (for example, ShiftJIS, GBK, Win1252). | ||
|
|
||
| ### Configuration parameters |
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
MD024/no-duplicate-heading Multiple headings with the same content [Context: "### Configuration parameters"]
Done! Don't worry about copying the errors out, I can see them in the web interface. If I get pinged I will try to fix them as I get time. =) |
This is subsequent PR of #1471.
Also I added the reason why we need to support these parameters and how
to use them.