Skip to content

pipeline: inputs: prometheus-remote-write: general cleanup - #1842

Merged
alexakreizinger merged 3 commits into
masterfrom
alexakreizinger/sc-136196/update-fluent-bit-docs-pipeline-inputs-prometheus
Jul 3, 2025
Merged

pipeline: inputs: prometheus-remote-write: general cleanup#1842
alexakreizinger merged 3 commits into
masterfrom
alexakreizinger/sc-136196/update-fluent-bit-docs-pipeline-inputs-prometheus

Conversation

@alexakreizinger

Copy link
Copy Markdown
Member

this PR is part of the effort to meet guidelines for style, clarity, and consistency.

Signed-off-by: Alexa Kreizinger <alexakreizinger@gmail.com>
@alexakreizinger
alexakreizinger requested review from a team as code owners July 2, 2025 20:52
# Prometheus remote write

This input plugin allows you to ingest a payload in the Prometheus remote-write format, i.e. a remote write sender can transmit data to Fluent Bit.
The _Prometheus remote write_ input plugin lets you ingest a payload in the Prometheus remote-write format. A remote-write sender can transmit data to Fluent Bit.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "remote-write" be hyphenated like that?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's how the prometheus remote-write protocol spec formats it, so I think so: https://prometheus.io/docs/specs/prw/remote_write_spec/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, looking at this again, they're somewhat inconsistent. but I think it makes sense to hyphenate :P

Comment thread pipeline/inputs/prometheus-remote-write.md Outdated

With the above configuration, Fluent Bit will listen on port `8080` for data.
You can now send payloads in Prometheus remote write format to the endpoint `/api/prom/push`.
These sample configurations configure Fluent Bit to listen for data on port `8080`. You can send payloads in Prometheus remote-write format to the endpoint `/api/prom/push`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about hyphenation.

@cnorris-cs cnorris-cs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments and suggestions, but I've added my approval based on those to keep this moving.

alexakreizinger and others added 2 commits July 3, 2025 10:33
Co-authored-by: Craig Norris <112565517+cnorris-cs@users.noreply.github.com>
Signed-off-by: Alexa Kreizinger <alexakreizinger@gmail.com>
…t-docs-pipeline-inputs-prometheus

Signed-off-by: Alexa Kreizinger <alexakreizinger@gmail.com>
@alexakreizinger
alexakreizinger merged commit a969db2 into master Jul 3, 2025
5 checks passed
@alexakreizinger
alexakreizinger deleted the alexakreizinger/sc-136196/update-fluent-bit-docs-pipeline-inputs-prometheus branch July 3, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants