Skip to content

Adding YAML examples to developers wasm filter plugin docs. Fixes #1768.#1769

Merged
patrick-stephens merged 2 commits into
fluent:masterfrom
eschabell:erics-dev-wasm-filter-plugins
Jun 24, 2025
Merged

Adding YAML examples to developers wasm filter plugin docs. Fixes #1768.#1769
patrick-stephens merged 2 commits into
fluent:masterfrom
eschabell:erics-dev-wasm-filter-plugins

Conversation

@eschabell

Copy link
Copy Markdown
Collaborator

Adding YAML examples to developers wasm filter plugin docs. Fixes #1768.

.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team as code owners June 20, 2025 13:52
WASM_Path /path/to/built_filter.wasm
Function_Name super_awesome_filter
accessible_paths .,/path/to/fluent-bit
accessible_paths /path/to/fluent-bit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking this change, is the original one a comma separated list with . allowing you to be path agnostic @cosmo0920 or is it just a typo?

@cosmo0920 cosmo0920 Jun 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't typo. Just including for the current working directory.
However, this should be removed if we pursue the rigid permission list approach.
Sometimes, I put Wasm programs into /path/to/fluent-bit/build directory and run fluent-bit in /path/to/fluent-bit/build directory. So, if we remove the magic . period symbol, we need to write the actual path of the place that contains the actual Wasm programs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add that info to the docs then I think, at least call it out in the example here

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I will add some text to refer to the fact that fluent bit needs to run from the same directory as the '/path/to/built_filter.wasm' file (aka the 'wasm_path').

…am app location.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@patrick-stephens
patrick-stephens merged commit 3a8ea0b into fluent:master Jun 24, 2025
5 checks passed
@eschabell
eschabell deleted the erics-dev-wasm-filter-plugins branch June 24, 2025 13:10
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
…ent#1768. (fluent#1769)

* Adding YAML examples to developers wasm filter plugin docs. Fixes #fluent#1768.

Signed-off-by: Eric D. Schabell <eric@schabell.org>

* Added comment for accessable_path and running Fluent Bit from the wasam app location.

Signed-off-by: Eric D. Schabell <eric@schabell.org>

---------

Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Tom <yao.lin@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing YAML examples for developers wasm filter plugin docs.

3 participants