Clarifying locking for included environments #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user asked for additional clarification of how locking of included environments works
github-actions
bot
added
the
documentation
mkenigs
commented
Oct 27, 2025
| In order for changes to be pulled in, the included environment must have a lockfile corresponding to the latest changes to the manifest. | ||
| For example, suppose an environment `my-go-project` includes a `go-tools` environment. | ||
| If the `manifest.toml` for `go-tools` is modified without using `flox edit`, then `flox include upgrade` for `my-go-project` won't be able use the changes to the `go-tools` manifest. | ||
| Using `flox edit` for `go-tools` would re-lock the environment using the latest manifest, and then `flox include upgrade` for `my-go-project` could pull in the changes. |
Contributor
Author
There was a problem hiding this comment.
I'm not 100% sold this is the right place to make the change. Can't decide if it's overexplaining the concept in the wrong place or not
zmitchell
approved these changes
Nov 6, 2025
| Running this command will check each of the included environments and determine if there were changes to their manifests. | ||
| If the changes to the manifest have been built by the included environment, then the new manifest will be included. | ||
| Running this command will check each of the included environments and check if the environments have changed. | ||
| In order for changes to be pulled in, the included environment must have a lockfile corresponding to the latest changes to the manifest. |
Member
There was a problem hiding this comment.
Suggested change
| In order for changes to be pulled in, the included environment must have a lockfile corresponding to the latest changes to the manifest. | |
| In order for changes to be pulled in, the manifest and lockfile of the the included environment must be in sync with one another (it's possible for them to get out of sync if you edit `manifest.toml` with your editor rather than `flox edit`). |
Suggestion: this reads a little smoother to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user asked for additional clarification of how locking of included environments works