Added Nicira (OpenVSwitch) exit, resubmit, and resubmit_table actions.#503
Added Nicira (OpenVSwitch) exit, resubmit, and resubmit_table actions.#503rsharo wants to merge 2 commits intofloodlight:masterfrom
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
…rt java type and IN_PORT as default.
|
java_type.py changes also tested with "make check-all", floodlight HEAD, and OVS 2.4.1. Not using |
|
@andi-bigswitch This looks good to me. Can we merge? |
|
@rizard - feel free to greenlight patches in loxigen when they look good to you... |
| @@ -0,0 +1,16 @@ | |||
| #version any | |||
There was a problem hiding this comment.
@rsharo sorry for the delay on this pull request. Do these apply to all OpenFlow versions? Everything looks good to me except for this (in each input file).
| @@ -0,0 +1,19 @@ | |||
| #version any | |||
| @@ -0,0 +1,20 @@ | |||
| #version any | |||
|
@rizard Yes, these same files apply to all OpenFlow versions. This was what made these Nicira extensions weird -- they did not make them handle 32-bit port IDs when moving to later OF versions, so you have to use 16-bit all the time. |
|
Find artifact changes from this pull request at https://github.com/floodlight/loxigen-artifacts/tree/PR-503-b1 |
1 similar comment
|
Find artifact changes from this pull request at https://github.com/floodlight/loxigen-artifacts/tree/PR-503-b1 |
4 participants
Tested with Floodlight master branch HEAD (7f62a18c1c1cd10c33532180b1d9c577213bd3c0) and OpenVSwitch 2.4.1. Also passes "make check-all".
Note that
of_action_nicira_resubmitandof_action_nicira_resubmit_tabletake a 16-bit OFPort for all OpenFlow protocol versions. Theportfield would ideally default to OFPort.IN_PORT if behavior is to match that ofovs-ofctl.Please reference Issue #501 if curious about the port number part.
Not sure how reviewer is chosen for this project. Please let me know what follow-up is needed.