fix: filter esms in sqs poller#447
Merged
hectorvent merged 1 commit intofloci-io:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
Author
|
the failed compatibility tests don't seem particularly related to what i changed? |
bkindersleytrulioo
changed the title
Collaborator
|
Thank you for the PR. I reran the test to double check the result, it could be some race conditions between services created by floci. |
Collaborator
|
Oh, tests finished all green. |
hectorvent
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #446
Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
SqsEventSourcePoller should only start polling for event source mappings that have sqs as a source. This matches what the other pollers are doing
Checklist
./mvnw testpasses locally (well, the same tests fail on main, anyways)(i'm not really sure how to test this?)