feat(ui): allow user to customize PR title by jgaul3 · Pull Request #6123 · flipt-io/flipt

jgaul3 · 2026-07-02T08:54:23Z

Description

Might be nice to let the user change the title of the resulting PR when they spin off their changes. Fully renders the template on the backend with proper branch names.

Screenshot

github-actions

Verdict: request changes

The PR correctly moves proposal template rendering to the backend so the UI can pre-fill editable defaults, which is a solid UX improvement. However, the prior review’s blocking concern is still unaddressed: Propose unconditionally renders templates and hard-fails on rendering errors even when the caller supplied a custom title and body that would discard the rendered result, regressing from the previous behavior.

internal/coss/storage/environments/git/store.go

major (L146): Propose unconditionally calls renderProposalDefaults and returns its error before checking opts.Title/opts.Body. Previously, supplying custom values skipped template execution entirely, so a broken or unreadable repository-level template did not block proposals. Now it does. Only render defaults when the caller hasn’t provided a value, or make template failure non-fatal when overrides are present.

🤖 Automated review by the Flipt PR review agent.

codecov · 2026-07-02T08:59:44Z

Codecov Report

❌ Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.26%. Comparing base (a3e5c1c) to head (4de80aa).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines	Patch %	Lines
internal/coss/storage/environments/git/store.go	0.00%	40 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v2    #6123      +/-   ##
==========================================
- Coverage   62.28%   62.26%   -0.02%     
==========================================
  Files         143      143              
  Lines       14729    14733       +4     
==========================================
  Hits         9174     9174              
- Misses       4809     4813       +4     
  Partials      746      746

Flag	Coverage Δ
integrationtests	`33.66% <0.00%> (-0.01%)`	⬇️
unittests	`53.68% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

markphelps

great idea @jgaul3 ! I think we need to reconcile this (and document) how proposal templates fit in though

markphelps · 2026-07-02T14:55:23Z


  const [proposeEnvironment] = useProposeEnvironmentMutation();

+  const defaultTitle = `Flipt: Update features ${


how does this work with the (not well documented at all) feature of templates?

flipt/config/local.yml

Line 37 in d2f4345

# proposal_title: "Flipt: Update features on {{.Base.Ref}}"

seems like it would always override?

Ah, that is just a flat oversight on my part, I thought the default we were working with was the one on the backend. How about I put in a new api endpoint to get the proposal title value?

I'm inclined to put the proposal title value on ListBranchedEnvironmentChangesResponse but could do it separately as well.

We have a GetInfo API that already has access to the Config object where templates are populated. And it returns a marshalled Flipt type where we could populate the template object onto. I believe the info value is already accessibile in the UI because we use it for things like theme

@markphelps Thanks for the feedback! The GetInfo API is much easier to use. A couple tradeoffs, it currently just shows the template. We could get the values to populate it in the frontend but the code to do the populating got pretty unpleasant. Or we could populate those branch / environment values in the backend, but I'm not sure I could see a way to do so via the GetInfo endpoint... Please let me know what you think of this crack at a solution and I'll adjust as needed.

yeah i see what you mean. ill add an API to get the rendered template from the backend so it can just be used by the frontend directly. will put up a pr today that we can rebase this one onto

So I just pushed a follow-up commit onto your branch (kept your commit as-is) that renders the proposal title/body on the backend from the hydrated templates and returns them via ListBranchedEnvironmentChanges, so the modal pre-fills the real, rendered default that the user can override.

The UI already called this to get the commits so no extra roundtrips

Thank you so much 🙏

Signed-off-by: Jon Gaul <jgaul3@gmail.com>

Render the merge-proposal title and body on the backend from the hydrated templates (built-in defaults overlaid with server- and repository-level overrides) and return them via ListBranchedEnvironmentChanges so the UI can pre-fill the form. Users may override the rendered defaults; caller-supplied values continue to be used verbatim. This replaces exposing the raw, unrendered server template through /meta/info, which could not reflect real branch refs or repo-level overrides and led to unrendered template syntax appearing in proposal titles. Also fixes a pre-existing Input.tsx ref type error surfaced by the UI build. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>

markphelps · 2026-07-08T19:18:47Z

@erka do you mind reviewing since I contributed to this branch?

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>

erka

nice one.

I bumped buf to 1.71 to match mise.

jgaul3 requested a review from a team as a code owner July 2, 2026 08:54

dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 2, 2026

github-actions Bot reviewed Jul 2, 2026

View reviewed changes

markphelps reviewed Jul 2, 2026

View reviewed changes

erka added the v2 Flipt v2 label Jul 3, 2026

github-project-automation Bot added this to Flipt V2 Jul 3, 2026

markphelps mentioned this pull request Jul 3, 2026

Document PR/commit templates config flipt-io/docs#411

Closed

jgaul3 force-pushed the custom-title branch from 9975818 to d78abe7 Compare July 7, 2026 04:33

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 7, 2026

feat(ui): allow user to customize PR title

880fb10

Signed-off-by: Jon Gaul <jgaul3@gmail.com>

jgaul3 force-pushed the custom-title branch from d78abe7 to 880fb10 Compare July 7, 2026 04:37

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 7, 2026

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 7, 2026

markphelps and others added 2 commits July 7, 2026 20:24

fix(ci): pin buf action version

5943424

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>

Merge branch 'v2' into custom-title

4cf9c82

markphelps requested a review from erka July 8, 2026 19:18

update CI to use buf v1.71.0, matching the mise configuration.

4de80aa

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>

erka approved these changes Jul 8, 2026

View reviewed changes

markphelps enabled auto-merge (squash) July 8, 2026 20:24

markphelps merged commit e4d1013 into flipt-io:v2 Jul 8, 2026
29 of 31 checks passed

github-project-automation Bot moved this to Done in Flipt V2 Jul 8, 2026


		const [proposeEnvironment] = useProposeEnvironmentMutation();

		const defaultTitle = `Flipt: Update features ${

Uh oh!

Uh oh!

Conversation

jgaul3 commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshot

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

internal/coss/storage/environments/git/store.go

Uh oh!

codecov Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

markphelps left a comment

Choose a reason for hiding this comment

Uh oh!

markphelps Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

jgaul3 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

jgaul3 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

markphelps Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

jgaul3 Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markphelps Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

markphelps Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

jgaul3 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

markphelps commented Jul 8, 2026

Uh oh!

erka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jgaul3 commented Jul 2, 2026 •

edited

Loading

github-actions Bot left a comment •

edited

Loading

codecov Bot commented Jul 2, 2026 •

edited

Loading

jgaul3 Jul 7, 2026 •

edited

Loading