Push -Wmissing-prototypes by default (#2438)

Author: albinahlback

Makefile.in

@@ -82,7 +82,8 @@ BLAS_LIB_PATH:=@BLAS_LIB_PATH@
 GC_LIB_PATH:=@GC_LIB_PATH@
 NTL_LIB_PATH:=@NTL_LIB_PATH@
 
-CFLAGS:=@CFLAGS@
+_CFLAGS:=@CFLAGS@
+CFLAGS=$(if $(filter inlines.c,$(notdir $<)),$(filter-out -Wmissing-prototypes,$(_CFLAGS)),$(_CFLAGS))
 TESTCFLAGS:=@TESTCFLAGS@
 CPPFLAGS:=-I$(ABS_SRC_DIR) -I$(SRC_DIR) @CPPFLAGS@ -DBUILDING_FLINT
 CPPFLAGS2:=-L$(ABS_FLINT_DIR) $(CPPFLAGS)
@@ -616,7 +617,7 @@ ifneq ($(STATIC), 0)
 define xxx_OBJS_rule
 $(BUILD_DIR)/$(1)/%.o: $(ABS_SRC_DIR)/$(1)/%.c | $(BUILD_DIR)/$(1)
 	$(MSG) "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
-	$(CMD) $(CC) $(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
+	$(CMD) $(CC) $$(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
 endef
 
 ifeq ($(IS_OUT_OF_TREE),1)
@@ -642,7 +643,7 @@ ifneq ($(SHARED), 0)
 define xxx_LOBJS_rule
 $(BUILD_DIR)/$(1)/%.lo: $(ABS_SRC_DIR)/$(1)/%.c | $(BUILD_DIR)/$(1)
 	$(MSG) "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
-	$(CMD) $(CC) $(PIC_FLAG) $(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
+	$(CMD) $(CC) $(PIC_FLAG) $$(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
 endef
 
 ifeq ($(IS_OUT_OF_TREE),1)

configure.ac

@@ -555,7 +555,7 @@ then
     gcc_cflags="-O3 "
 fi
 gcc_cflags="$gcc_cflags-pedantic -std=c11"
-gcc_warnings="-Werror=implicit-function-declaration -Werror=newline-eof -Wall -Wno-stringop-overread -Wno-stringop-overflow"
+gcc_warnings="-Wall -Werror=implicit-function-declaration -Werror=newline-eof -Wno-stringop-overread -Wno-stringop-overflow -Wmissing-prototypes"
 
 dnl We only try to provide specifics for those systems that currently supports
 dnl our assembly routines. If more combinations are wished for than what is
@@ -1344,7 +1344,8 @@ fi
 
 if test "$testcflags_set" = "no";
 then
-    TESTCFLAGS="$CFLAGS"
+    # Remove -Wmissing-prototypes from test files
+    TESTCFLAGS=$(printf '%s\n' "$CFLAGS" | sed 's/-Wmissing-prototypes//g')
 else
     TESTCFLAGS="$TESTCFLAGS $save_CFLAGS"
 fi