Silence some warnings (#2429)

albinahlback · web-flow · commit 2e5bd15f9db3 · 2025-10-29T10:45:03.000+01:00
diff --git a/src/acb_theta/ql_exact.c b/src/acb_theta/ql_exact.c
@@ -400,10 +400,7 @@ acb_theta_ql_perform_steps(acb_ptr th, acb_ptr th_init, acb_srcptr rts,
     th_next = _acb_vec_init(3 * n * nb);
     d = _arb_vec_init(n);
     d0 = _arb_vec_init(n);
-    if (all)
-    {
-        aux = _acb_vec_init(n * n);
-    }
+    aux = (all) ? _acb_vec_init(n * n) : NULL;
 
     for (k = nb_steps - 1; k >= 0; k--)
     {
@@ -519,10 +516,7 @@ acb_theta_ql_exact_steps(acb_ptr th, acb_srcptr zs, slong nb,
     th_init = _acb_vec_init(3 * n * nb);
     easy_steps = flint_malloc(nb * sizeof(slong));
     acb_mat_init(new_tau, g, g);
-    if (all)
-    {
-        rts_all = _acb_vec_init(nb * n * n);
-    }
+    rts_all = (all) ? _acb_vec_init(nb * n * n) : NULL;
 
     res = acb_theta_ql_setup(rts, rts_all, t, &guard, easy_steps, zs, nb, tau, distances,
         nb_steps, all, prec);
diff --git a/src/fmpq_mpoly/get_coeff_fmpq_fmpz.c b/src/fmpq_mpoly/get_coeff_fmpq_fmpz.c
@@ -63,7 +63,7 @@ void fmpq_mpoly_get_coeff_fmpq_fmpz(fmpq_t c, const fmpq_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
diff --git a/src/fmpq_mpoly/get_coeff_fmpq_ui.c b/src/fmpq_mpoly/get_coeff_fmpq_ui.c
@@ -19,7 +19,7 @@ void fmpq_mpoly_get_coeff_fmpq_ui(fmpq_t c, const fmpq_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/fmpq_mpoly/set_coeff_fmpq_fmpz.c b/src/fmpq_mpoly/set_coeff_fmpq_fmpz.c
@@ -110,7 +110,7 @@ void fmpq_mpoly_set_coeff_fmpq_fmpz(fmpq_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
diff --git a/src/fmpq_mpoly/set_coeff_fmpq_ui.c b/src/fmpq_mpoly/set_coeff_fmpq_ui.c
@@ -20,7 +20,7 @@ void fmpq_mpoly_set_coeff_fmpq_ui(fmpq_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/fmpz_mod_mpoly/set_coeff_fmpz_ui.c b/src/fmpz_mod_mpoly/set_coeff_fmpz_ui.c
@@ -19,7 +19,7 @@ void fmpz_mod_mpoly_set_coeff_fmpz_ui(fmpz_mod_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/fmpz_mpoly/set_coeff_fmpz_fmpz.c b/src/fmpz_mpoly/set_coeff_fmpz_fmpz.c
@@ -84,7 +84,7 @@ void fmpz_mpoly_set_coeff_fmpz_fmpz(fmpz_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
diff --git a/src/fmpz_mpoly/set_coeff_fmpz_ui.c b/src/fmpz_mpoly/set_coeff_fmpz_ui.c
@@ -20,7 +20,7 @@ void fmpz_mpoly_set_coeff_fmpz_ui(fmpz_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/fq_nmod_mpoly/set_coeff_fq_nmod_fmpz.c b/src/fq_nmod_mpoly/set_coeff_fq_nmod_fmpz.c
@@ -94,7 +94,7 @@ void fq_nmod_mpoly_set_coeff_fq_nmod_fmpz(
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
diff --git a/src/fq_nmod_mpoly/set_coeff_fq_nmod_ui.c b/src/fq_nmod_mpoly/set_coeff_fq_nmod_ui.c
@@ -20,7 +20,7 @@ void fq_nmod_mpoly_set_coeff_fq_nmod_ui(fq_nmod_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/gr_mat/qr.c b/src/gr_mat/qr.c
@@ -74,8 +74,7 @@ int
 gr_mat_lq_recursive(gr_mat_t L, gr_mat_t Q, const gr_mat_t A, gr_ctx_t ctx)
 {
     int status = GR_SUCCESS;
-    slong sz = ctx->sizeof_elem;
-    slong m, n, d, i, k;
+    slong m, n, d;
     gr_mat_t A1, A2, Q1, Q2, L11, L12, L21, L22, QT, T;
 
     m = gr_mat_nrows(A, ctx);
diff --git a/src/nmod_mpoly/get_term_ui_fmpz.c b/src/nmod_mpoly/get_term_ui_fmpz.c
@@ -58,7 +58,7 @@ ulong nmod_mpoly_get_term_ui_fmpz(const nmod_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
diff --git a/src/nmod_mpoly/get_term_ui_ui.c b/src/nmod_mpoly/get_term_ui_ui.c
@@ -21,7 +21,7 @@ ulong nmod_mpoly_get_term_ui_ui(const nmod_mpoly_t poly,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 
diff --git a/src/nmod_mpoly/set_coeff.c b/src/nmod_mpoly/set_coeff.c
@@ -94,7 +94,7 @@ void nmod_mpoly_set_coeff_ui_fmpz(
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
     {
         fmpz_init(newexp + i);
@@ -144,7 +144,7 @@ void nmod_mpoly_set_coeff_ui_ui(nmod_mpoly_t A,
     TMP_INIT;
 
     TMP_START;
-    newexp = (fmpz *) TMP_ALLOC(nvars*sizeof(fmpz));
+    newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;
     for (i = 0; i < nvars; i++)
         fmpz_init_set_ui(newexp + i, exp[i]);
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ void fmpq_mpoly_get_coeff_fmpq_fmpz(fmpq_t c, const fmpq_mpoly_t poly,`
`63`	`63`	`TMP_INIT;`
`64`	`64`
`65`	`65`	`TMP_START;`
`66`		`- newexp = (fmpz ) TMP_ALLOC(nvarssizeof(fmpz));`
	`66`	`+ newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;`
`67`	`67`	`for (i = 0; i < nvars; i++)`
`68`	`68`	`{`
`69`	`69`	`fmpz_init(newexp + i);`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ void fmpq_mpoly_set_coeff_fmpq_fmpz(fmpq_mpoly_t poly,`
`110`	`110`	`TMP_INIT;`
`111`	`111`
`112`	`112`	`TMP_START;`
`113`		`- newexp = (fmpz ) TMP_ALLOC(nvarssizeof(fmpz));`
	`113`	`+ newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;`
`114`	`114`	`for (i = 0; i < nvars; i++)`
`115`	`115`	`{`
`116`	`116`	`fmpz_init(newexp + i);`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ void fmpz_mpoly_set_coeff_fmpz_fmpz(fmpz_mpoly_t poly,`
`84`	`84`	`TMP_INIT;`
`85`	`85`
`86`	`86`	`TMP_START;`
`87`		`- newexp = (fmpz ) TMP_ALLOC(nvarssizeof(fmpz));`
	`87`	`+ newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;`
`88`	`88`	`for (i = 0; i < nvars; i++)`
`89`	`89`	`{`
`90`	`90`	`fmpz_init(newexp + i);`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ void fq_nmod_mpoly_set_coeff_fq_nmod_fmpz(`
`94`	`94`	`TMP_INIT;`
`95`	`95`
`96`	`96`	`TMP_START;`
`97`		`- newexp = (fmpz ) TMP_ALLOC(nvarssizeof(fmpz));`
	`97`	`+ newexp = (nvars > 0) ? TMP_ALLOC(nvars*sizeof(fmpz)) : NULL;`
`98`	`98`	`for (i = 0; i < nvars; i++)`
`99`	`99`	`{`
`100`	`100`	`fmpz_init(newexp + i);`