Skip to content

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Dec 30, 2025

i18next-parser is now deprecated and bringing some old dependencies.

Run npx i18next-cli migrate-config i18next-parser.config.js to correctly migrate the config file.

Summary by CodeRabbit

  • Chores
    • Updated internationalization tooling configuration and replaced underlying translation extraction dependencies with a new framework.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Walkthrough

The pull request migrates the i18n tooling from i18next-parser to i18next-cli. It replaces the old parser configuration file with a new TypeScript-based CLI configuration, updates related package dependencies in two package.json files, and adjusts the extraction script command accordingly.

Changes

Cohort / File(s) Summary
Configuration Migration
libs/i18n/i18next-parser.config.js, libs/i18n/i18next.config.ts
Removed old i18next-parser configuration (createOldCatalogs, keySeparator, locales, namespaceSeparator, reactNamespace, defaultValue function). Introduced new i18next-cli TypeScript configuration defining extraction rules for JS/TS files under libs/apps, output path for translations, and TypeScript type generation at src/types/i18next.d.ts.
Package & Script Updates
libs/i18n/package.json, package.json
Replaced devDependency i18next-parser (v6.5.0) with i18next-cli (^1.5.11) in both files. Updated "i18n" script in libs/i18n/package.json from complex i18next invocation with parser config to simplified i18next-cli extract command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: migrating from i18next-parser to i18next-cli. The changeset shows deletion of i18next-parser config, addition of i18next-cli config, and dependency replacement across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the migrate-i18next-parser branch from 87107fb to 2a088ad Compare December 30, 2025 14:14
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

44-44: Consider updating i18next-cli to a more recent stable version.

The specified version ^1.5.11 is significantly outdated; the latest stable release is v1.33.5. While the caret operator will allow npm to install newer 1.x releases automatically, explicitly targeting a more recent version like ^1.33.5 would be clearer and ensure the latest features and improvements are captured. No known security vulnerabilities were found for v1.5.11.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08029e1 and 2a088ad.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • libs/i18n/i18next-parser.config.js
  • libs/i18n/i18next.config.ts
  • libs/i18n/locales/en/translation.json
  • libs/i18n/package.json
  • package.json
💤 Files with no reviewable changes (1)
  • libs/i18n/i18next-parser.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: integration-tests
  • GitHub Check: Lint
🔇 Additional comments (4)
libs/i18n/package.json (1)

10-10: Simplified extraction script looks good.

The new script is cleaner and the git diff check ensures translation files are kept in sync during CI runs.

libs/i18n/i18next.config.ts (3)

5-13: Extract configuration is well-structured.

The input path pattern correctly targets all workspace source files, and the extraction settings (functions, transComponents, separators) cover standard i18next usage patterns appropriately.


14-17: Type generation is a valuable addition.

The types configuration will generate TypeScript declarations from translation files, providing type safety for translation keys—a significant improvement over i18next-parser.


1-3: No issues found. The defineConfig import and usage pattern is correct and follows the official i18next-cli API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant