Run shell before the start of the build #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does change the behavior since previously it would configure the project, then open a shell, now it just opens a shell. I'm not sure this distinction matters or not but another possibility is if |
Yes please, otherwise how am I suppose to debug a module that fails in configure step? if I'm not able to open a shell in that case.. |
|
This sounds like the better fix to me #625 (comment) You opened the PR from your main branch and I can't rebase it, @koko-ng can you rebase this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
For some build systems there were calls to
buildbeforeshell, which made it impossible to open a shell in the build environment if the build failed. I don't think that movingshellbefore has an implication on the environment as the code in between only seems to do checks on the project.Fixes #479