This repository was archived by the owner on May 12, 2025. It is now read-only.
fix: Iterate pendingWrites backward to get the last updated value #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pistomat
requested review from
Ruteri,
dmarzzz,
ferranbt and
metachris
as code owners
0x416e746f6e
approved these changes
Nov 13, 2024
Member
0x416e746f6e
left a comment
0x416e746f6e
left a comment
There was a problem hiding this comment.
reviewing upon request from Michał
looks good for my rather limited understanding of the problem and underlying code-base
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Multiple
Storeoperations in a single CCR append the values topendingWrites, which makes it sorted by time ascending. When doing aRetrievethe list ofpendingWriteswas iterated from oldest to newest, which means only the first stored value for a given key was ever returned. This PR iterates overpendingWritesin reverse so the latest stored value is returned.