Merged
Conversation
Member
|
thanks @0xl3on -- should be able to review tomorrow! |
zeroXbrock
reviewed
Mar 12, 2026
Member
zeroXbrock
left a comment
There was a problem hiding this comment.
nice work, this is great! Had a good bit of fun testing this.
One thing I might add -- can we log the responses from the RPC calls? I can see from my node's logs that the RPC calls are working, but I think it would be helpful to see what the endpoints are returning, in case the user provides erroneous input (erroneous to the method call but passable by the serializer)
zeroXbrock
approved these changes
Mar 16, 2026
Member
zeroXbrock
left a comment
There was a problem hiding this comment.
looks good, thanks @0xl3on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hey guys, pretty big feature so sorry for the big PR:
Closes #462
Each RPC method is strongly typed clap subcommand, as mentioned in the issue.
eth_sendRawTransactionis excluded because nonce is baked into the signed payload so spamming would fail.Solution
Changes from existing code:
test_scenario.rsto a shared function atbucket.rsso we can re-use across tx and rpc spamNew code
PR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crate