feat: add sync raw send transaction support#459
feat: add sync raw send transaction support#4590xl3on wants to merge 5 commits intoflashbots:mainfrom
Conversation
|
Hey @zeroXbrock ! Closing one more stale issue. Lmk your thoughts! |
|
Thanks @0xl3on! I'm OOO for the next couple weeks so I'll ask someone from my team if they can review. But if not I'll review it when I'm back! |
There was a problem hiding this comment.
nice, works as expected!
Just one thing I'd like to change though: the call to eth_sendRawTransactionSync doesn't show up in reports (neither on the eth_sendRawTransaction Latency graph or the latency quantile table). Naturally, the eth_sendRawTransaction chart renders empty because we didn't call that method, but it would be nice to add a chart for eth_sendRawTransactionSync that takes the place of the eth_sendRawTransaction Latency chart when applicable. Charts with no data should simply not render in the report, and the latency chart should include every method called during the run.
| pub fn start_timestamp_ms(&self) -> u128 { | ||
| self.start_timestamp_ms | ||
| } | ||
|
|
||
| pub fn end_timestamp_ms(&self) -> Option<u128> { | ||
| self.end_timestamp_ms | ||
| } | ||
|
|
There was a problem hiding this comment.
if these vars need to be read outside of the crate, we should probably just remove these getter functions and make the params public
Motivation
Closes #429
Solution
end_timestamp_ms right when the response arrives
timestamps
(existing behavior, unchanged)
PR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crate