feat(docs): add hash custom instructions and rearange guides#1400
Merged
Conversation
nikerzetic-aflabs
changed the title
fassko
requested changes
May 20, 2026
|
|
||
| Unlike the custom instruction, which carries only `keccak256(userOp)` in the memo, this header is followed by the full ABI-encoded `PackedUserOperation` - hence the memo cap problem above. | ||
|
|
||
| ## Sending the user operation |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Sending the user operation | |
| ## Sending the User Operation |
|
|
||
| ## Sending the user operation | ||
|
|
||
| The XRPL `Payment` is sent to the FAssets **direct minting payment address** read from the `AssetManagerFXRP` contract - not to an operator wallet. |
Collaborator
There was a problem hiding this comment.
Suggested change
| The XRPL `Payment` is sent to the FAssets **direct minting payment address** read from the `AssetManagerFXRP` contract - not to an operator wallet. | |
| The XRPL `Payment` is sent to the FAssets [direct minting payment address](/fassets/reference/IAssetManager#directmintingpaymentaddress) read from the `AssetManagerFXRP` contract - not to an operator wallet. |
| There is no `(data, totalCallValue)` to hand off to an executor here: the entire user operation already lives in the memo, so the only handoff is the XRPL payment itself. | ||
| The `xrplClient` and `xrplWallet` are the `Client` and `Wallet` classes from the `xrpl` library, initialized from the `.env` file. | ||
|
|
||
| ## Waiting for execution |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Waiting for execution | |
| ## Waiting for Execution |
| If any inner call reverts, the whole user operation reverts with [`CallFailed`](/smart-accounts/reference/IPersonalAccount#callfailed) and the nonce does not increment. | ||
| The FXRP transfer, however, is performed before the memo is decoded, so the mint succeeds even when the user operation reverts - see [`DirectMintingExecuted`](/smart-accounts/reference/IMasterAccountController#directmintingexecuted). | ||
|
|
||
| ## Full script |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Full script | |
| ## Full Script |
| {RawCustomInstructionsScript} | ||
| </CodeBlock> | ||
|
|
||
| ## Expected output |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Expected output | |
| ## Expected Output |
fassko
requested changes
May 20, 2026
Collaborator
fassko
left a comment
fassko
left a comment
There was a problem hiding this comment.
Somehow, I don't like the raw custom instruction name, but that can stay.
Co-authored-by: Kristaps Grinbergs <fassko@gmail.com>
nikerzetic-aflabs
force-pushed
the
hash-custom-instructions
branch
from
ef39bd7 to
dddcfaf
Compare
fassko
requested changes
May 21, 2026
nikerzetic-aflabs
force-pushed
the
hash-custom-instructions
branch
from
5f029da to
d0c9a6f
Compare
fassko
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.