Add headphones notice #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a headphones recommendation to enhance the user experience during gameplay by promoting better audio quality and reducing echo during voice communication.
Key Changes:
- Created a new
HeadphonesNoticecomponent displaying a visual recommendation for headphone use - Added the notice to the join screen where users set up their audio/video devices
- Updated the "How to Play" tips section to include headphone recommendation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
deep-sea-stories/packages/web/src/components/HeadphonesNotice.tsx |
New component displaying headphones recommendation with icon and descriptive text |
deep-sea-stories/packages/web/src/views/JoinView.tsx |
Integrated HeadphonesNotice component into the device setup section |
deep-sea-stories/packages/web/src/components/HowToPlay.tsx |
Added tip about using headphones for optimal audio experience |
deep-sea-stories/packages/web/src/components/PeerTile.tsx |
Added fallback text when user name is not provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Gawor270
requested review from
AHGIJMKLKKZNPJKQR and
czerwiukk
and removed request for
AHGIJMKLKKZNPJKQR
czerwiukk
reviewed
Dec 9, 2025
Member
czerwiukk
left a comment
czerwiukk
left a comment
There was a problem hiding this comment.
in a case of a simple ui change, please consider attaching screenshots to the PR, it'd make reviews simpler
Member
my only blocking suggestion would be to make the "headphones info" element width to fit the content and center it instead of spanning all over the parent, otherwise lgtm |
Member
Author
Now it looks like this
|
czerwiukk
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining room recommend user to use headphones, also when video nor name is provided display 'Video Unavailable'