Skip to content

issues with _UID generation#5293

Open
BertKoor wants to merge 1 commit intofisharebest:mainfrom
BertKoor:issue4828_UIDgeneration
Open

issues with _UID generation#5293
BertKoor wants to merge 1 commit intofisharebest:mainfrom
BertKoor:issue4828_UIDgeneration

Conversation

@BertKoor
Copy link
Contributor

@BertKoor BertKoor commented Jan 21, 2026

fix: #4828, #5261

Generation of a new _UID when mandatory is the responsibility of GedcomImportService, and should not be done elsewhere.

PafUid->canonical() should NOT generate a value, even when absent. This was causing it getting a value even when none was required, possibly even CHANGING existing values which should never occur.

Changed _UID tag to hidden for OBJE, REPO & SOUR, can be put on the form with button "Edit with all GEDCOM tags" when needed.

…lity of GedcomImportService.

PafUid->canonical should NOT generate a value, even when absent.
_UID tag made hidden for OBJE, REPO & SOUR.
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.20%. Comparing base (2b3a3e6) to head (ddc1b8a).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
app/Gedcom.php 0.00% 3 Missing ⚠️
app/Elements/PafUid.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5293   +/-   ##
=========================================
  Coverage     35.20%   35.20%           
  Complexity    11236    11236           
=========================================
  Files          1159     1159           
  Lines         48108    48108           
=========================================
  Hits          16937    16937           
  Misses        31171    31171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BertKoor BertKoor changed the title fix #4828 - issues with _UID issues with _UID generation Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record has multiple uid fields

1 participant