Open
Conversation
…lity of GedcomImportService. PafUid->canonical should NOT generate a value, even when absent. _UID tag made hidden for OBJE, REPO & SOUR.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5293 +/- ##
=========================================
Coverage 35.20% 35.20%
Complexity 11236 11236
=========================================
Files 1159 1159
Lines 48108 48108
=========================================
Hits 16937 16937
Misses 31171 31171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #4828, #5261
Generation of a new _UID when mandatory is the responsibility of GedcomImportService, and should not be done elsewhere.
PafUid->canonical() should NOT generate a value, even when absent. This was causing it getting a value even when none was required, possibly even CHANGING existing values which should never occur.
Changed _UID tag to hidden for OBJE, REPO & SOUR, can be put on the form with button "Edit with all GEDCOM tags" when needed.