Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=============================================
+ Coverage 35.49% 48.04% +12.55%
- Complexity 11211 11783 +572
=============================================
Files 1166 1211 +45
Lines 48077 53629 +5552
=============================================
+ Hits 17065 25767 +8702
+ Misses 31012 27862 -3150 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I like the idea of using the SVG icons for the silhouette image. Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid We should use the same image in the chart boxes. Perhaps create a new view (e.g. resources/views/silhouette.phtml) that we can use for both. I see that the code for thumbnail images / silhouettes is slightly different for chartboxes and the individual page. I need to make this consistent. |
|
Updated this PR. Description is in the first comment. |
|
Hi @fisharebest, |
Should not affect supplied themes, until "content" CSS property is unset for parent element.Suggestion for #5049.
Reworked PR to use more "human" images.
Images are from @magicsunday here: https://github.com/magicsunday/webtrees-fan-chart/tree/f7029367c384237249d73ff1241ea0203dc1e24a/resources/images
Not sure exactly how to incorporate SVG images into webtrees. I guess resources/views/icons is intended for smaller icon images, not really this kind of image.
Consider this PR as a POC for the time being.
Minimal theme is adapted to use the new images.
I have not yet touched the smaller silhouette images.
Sample images

