Skip to content

Add default SVG silhouette images - #5088

Open
ekdahl wants to merge 14 commits into
fisharebest:mainfrom
ekdahl:svg-silhouettes
Open

ekdahl wants to merge 14 commits into
fisharebest:mainfrom
ekdahl:svg-silhouettes

Conversation

@ekdahl

@ekdahl ekdahl commented Dec 28, 2024 •

Copy link
Copy Markdown
Contributor

Should not affect supplied themes, until "content" CSS property is unset for parent element.
Suggestion for #5049.

Sample images
image
image

@codecov

codecov Bot commented Dec 28, 2024 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.04%. Comparing base (a64cc99) to head (349afbc).
⚠️ Report is 325 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #5088       +/-   ##
=============================================
+ Coverage     35.49%   48.04%   +12.55%     
- Complexity    11211    11783      +572     
=============================================
  Files          1166     1211       +45     
  Lines         48077    53629     +5552     
=============================================
+ Hits          17065    25767     +8702     
+ Misses        31012    27862     -3150     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisharebest

Copy link
Copy Markdown
Owner

I like the idea of using the SVG icons for the silhouette image.

Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid

We should use the same image in the chart boxes.

Perhaps create a new view (e.g. resources/views/silhouette.phtml) that we can use for both.

I see that the code for thumbnail images / silhouettes is slightly different for chartboxes and the individual page. I need to make this consistent.

@ekdahl
ekdahl force-pushed the svg-silhouettes branch from ed12be6 to d3730ed Compare May 11, 2026 19:43
@ekdahl

ekdahl commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Updated this PR. Description is in the first comment.

@ekdahl ekdahl changed the title Add default SVG silhouette icon Add default SVG silhouette images May 11, 2026
@ekdahl

ekdahl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi @fisharebest,
Did you see the update to this PR?
I think the SVG profile images from @magicsunday looks really nice and it would be a nice addition to use them in webtrees.

This branch was previously deployed

1 inactive deployment
codecov — 349afbc3 Deployed Oct 26, 2026 by ekdahl via phpunit (8.3) #6985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants