Skip to content

locations-edit.phtml reorganise layout - #4756

Closed
ddrury wants to merge 2 commits into
fisharebest:mainfrom
ddrury:Locations_add_form_to_fullscreen
Closed

locations-edit.phtml reorganise layout#4756
ddrury wants to merge 2 commits into
fisharebest:mainfrom
ddrury:Locations_add_form_to_fullscreen

Conversation

@ddrury

@ddrury ddrury commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

Re-organise page layout to make it easier to include form on fullscreened page.

218336337-61d0fa02-991e-486e-98a1-ddf16779b0b5

218336543-bb9d939c-3621-4f27-b28a-0f53276e9472

@codecov

codecov Bot commented Feb 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4756 (d1369bd) into main (aa167c4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4756   +/-   ##
=========================================
  Coverage     30.92%   30.92%           
  Complexity    11361    11361           
=========================================
  Files          1174     1174           
  Lines         47893    47893           
=========================================
  Hits          14812    14812           
  Misses        33081    33081           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ddrury

ddrury commented Feb 15, 2023

Copy link
Copy Markdown
Contributor Author

For floating labels see
twbs/bootstrap#33999 (which indicates working as designed!) and
https://codepen.io/broofa/pen/gOmwVPz and
twbs/bootstrap#36155

@fisharebest

Copy link
Copy Markdown
Owner

Re-organise page layout to make it easier to include form on fullscreened page.

Yup - this is good.

But floating labels? I don't get why.

I merged in the first part.

@fisharebest fisharebest closed this Apr 3, 2023
@ddrury

ddrury commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

But floating labels? I don't get why.

I thought they looked nice and the html was simpler

@ddrury
ddrury deleted the Locations_add_form_to_fullscreen branch April 4, 2023 08:45
ddrury pushed a commit to ddrury/webtrees that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants