multi-domain assembly

[leo-collins]

allow assembly of uncoupled multi-domain problems

[connorjward]

I wonder if all this logic should simply be

[leo-collins]

Don't merge, it isn't right yet

[connorjward]

Don't merge, it isn't right yet

Please leave this as a draft PR then

[leo-collins]

@connorjward Can this be merged? The errors look unrelated.

[connorjward]

I agree. @UZerbinati it looks like your merges into ngsPETSc have broken things. I will try to fix them when I move things over (imminently).

[UZerbinati]

I agree. @UZerbinati it looks like your merges into ngsPETSc have broken things. I will try to fix them when I move things over (imminently).

I don't see what I've broken, all Firedrake test's passed in ngsPETSc before merging.

@connorjward so the incriminated line seems to be:
mesh.geometric_dimension()
which doesn't raise any error in the Firedrake docker container which we use for testing in ngsPETSc. When did this behavior change ?

Also this error is not reproducible in my local machine with a new Firedrake installation :(

[connorjward]

I don't see what I've broken, all Firedrake test's passed in ngsPETSc before merging.

They passed on Firedrake release branch, not main.

When did this behavior change ?

See #4629

[connorjward]

I fixed this for ngsPETSc in NGSolve/ngsPETSc#94, before you made more changes.

It's fine. Release still works which is the most important thing. I'll sort this all out tomorrow hopefully.