Make assembly of interpolation matrices respect mat_type
#4749
+377
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-collins
changed the title
mat_type
leo-collins
commented
Nov 26, 2025
pbrubeck
reviewed
Nov 26, 2025
connorjward
requested changes
Nov 27, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Looks pretty good. I wish you'd stop changing all this code though as I have to keep fixing my own :')
dham
previously approved these changes
Dec 2, 2025
Contributor
Author
|
@connorjward Can this be merged now? |
connorjward
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make assembly of two-form
interpolates respect themat_typekwarg in assembly. Two-form interpolations always assemble to PETSc aij by default now, the same as for all other two-forms. To assemble a two-form interpolation between MixedFunctionSpaces into a MatNest, doassemble(interpolate(TrialFunction(V), U), mat_type="nest")