feat(virtio-pmem): add a Drop implementation #5553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5553 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 277 277
Lines 29248 29251 +3
=======================================
+ Hits 24357 24360 +3
Misses 4891 4891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
pmem_drop
branch
from
fbcec45 to
2994e58
Compare
Event though during Firecracker normal run pmem devices are never removed, so there is no need to unmap memory, it is important for fuzzer runs, as otherwise it runs out of virtual memory. Additionally make `mmap_backing_file` private since it is only called from within Pmem device. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
pmem_drop
branch
from
2994e58 to
9a1b731
Compare
kalyazin
approved these changes
Dec 2, 2025
Manciukic
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Event though during Firecracker normal run pmem devices are never removed, so there is no need to unmap memory, it is important for fuzzer runs, as otherwise it runs out of virtual memory.
Additionally make
mmap_backing_fileprivate since it is only called from within Pmem device.Reason
Makes fuzzing possible
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.