Skip to content

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 29, 2025

Renamed the FirebaseAI module to FirebaseAILogic to work around a Swift issue (swiftlang/swift#43510), which occurs when a type has the same name as the module (the FirebaseAI class and module in this case). See
"Fixing modules that contain a type with the same name" for more information. This resolves the zip distribution issue reported in #15272.

Note: Existing clients can continue to use the FirebaseAI module and import but it will be removed in a future breaking release in favour of FirebaseAILogic.

#no-changelog

@andrewheard andrewheard added this to the 12.4.0 - M171 milestone Sep 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the FirebaseAI module by renaming it to FirebaseAILogic and introducing a new FirebaseAI wrapper module that re-exports FirebaseAILogic. This is a good structural change that aligns with patterns in other Firebase SDKs. The changes are mostly mechanical renaming across many files. I've found a couple of areas for improvement in the podspec and Swift Package Manager configuration to enhance maintainability and correctness. Overall, the changes look good.

@ncooke3 ncooke3 modified the milestones: 12.4.0 - M171, 12.5.0 - M172 Oct 2, 2025
@andrewheard
Copy link
Contributor Author

Attempting to fix quickstart_framework_firebaseai with firebase/quickstart-ios#1783.

@andrewheard andrewheard marked this pull request as ready for review October 16, 2025 01:36
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the FirebaseAI module to FirebaseAILogic to work around a Swift compiler issue. A new FirebaseAI wrapper module is introduced for backward compatibility, which is a good approach. The changes are comprehensive, updating podspecs, Swift Package Manager configurations, and tests accordingly. The implementation is solid, but I have one suggestion to improve dependency management in the podspec.

@andrewheard andrewheard merged commit a98ea60 into main Oct 16, 2025
172 of 174 checks passed
@andrewheard andrewheard deleted the ah/ai-logic-rename branch October 16, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants