-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Firebase AI] Rename module to FirebaseAILogic
#15275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
# Conflicts: # FirebaseAI.podspec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the FirebaseAI
module by renaming it to FirebaseAILogic
and introducing a new FirebaseAI
wrapper module that re-exports FirebaseAILogic
. This is a good structural change that aligns with patterns in other Firebase SDKs. The changes are mostly mechanical renaming across many files. I've found a couple of areas for improvement in the podspec and Swift Package Manager configuration to enhance maintainability and correctness. Overall, the changes look good.
Attempting to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request renames the FirebaseAI
module to FirebaseAILogic
to work around a Swift compiler issue. A new FirebaseAI
wrapper module is introduced for backward compatibility, which is a good approach. The changes are comprehensive, updating podspecs, Swift Package Manager configurations, and tests accordingly. The implementation is solid, but I have one suggestion to improve dependency management in the podspec.
Renamed the
FirebaseAI
module toFirebaseAILogic
to work around a Swift issue (swiftlang/swift#43510), which occurs when a type has the same name as the module (theFirebaseAI
class and module in this case). See"Fixing modules that contain a type with the same name" for more information. This resolves the zip distribution issue reported in #15272.
Note: Existing clients can continue to use the
FirebaseAI
module and import but it will be removed in a future breaking release in favour ofFirebaseAILogic
.#no-changelog