-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[realppl 9] realppl public api and integration tests #14931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wuandy/RealPpl_8
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
|
|
||
| @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *) | ||
| public struct PipelineSource: @unchecked Sendable { | ||
| public struct PipelineSource<P>: @unchecked Sendable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andy, I remember in the discussion we decided to avoid using generic and go with RealtimePipelineSource ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some source, for example database is not available for the realtime ppl (although we can relay on runtime checking)
f7273d4 to
676dc22
Compare
c33f64a to
020bfbc
Compare
38b72bd to
c2bf5ec
Compare
9a4b558 to
fb16f96
Compare
c2bf5ec to
b5ad143
Compare
fb16f96 to
f85881b
Compare
5a19c8f to
8b8d4a2
Compare
f85881b to
0d65b86
Compare
8b8d4a2 to
70c3278
Compare
3c2fbf7 to
b9d0d1a
Compare
70c3278 to
27a4b92
Compare
b9d0d1a to
f28fc1d
Compare
bf5a534 to
e059610
Compare
f28fc1d to
7fdd160
Compare
e059610 to
8d1e709
Compare
c9c5990 to
a99fe2e
Compare
8d1e709 to
587b678
Compare
a99fe2e to
ac94a87
Compare
c6f2775 to
0e39951
Compare
ac94a87 to
016dac0
Compare
016dac0 to
dde6ee9
Compare
0e39951 to
042515a
Compare
No description provided.