Improve UI controls and state handling - #23
Merged
Conversation
allkhor
force-pushed
the
fix-fan-controls
branch
from
September 28, 2025 19:44
7f8f4c2 to
d7e0e05
Compare
Contributor
Author
|
Deleted stray console.log calls that were left in the code during debugging and fix lint errors |
allkhor
force-pushed
the
fix-fan-controls
branch
from
September 28, 2025 20:01
d7e0e05 to
857b6e4
Compare
Owner
|
@allkhor Thank you. I will take a look tonight. |
Contributor
Author
|
I think the Action failed and it's unrelated to this PR. |
Owner
|
Id like to keep the build. But the push to ghcr.io fails for some auth reason. We might only push on main. I am fine with not having the action succeed. |
Owner
|
Thank you for your contribution. |
Contributor
Author
|
Thanks! That’s exactly what this project is about — giving users freedom and control over their devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce SmartControls, a reusable abstraction for managing local UI state,
debounced commits, and synchronization with backend values. This resolves the
issue where adjusting a slider was overwritten by incoming backend updates.
Changes
createSmartControlto handle UI interaction, pending state, andtimed commits.
toPercent– converts UI values (0‑15) to percentage display.scaleSliderToBackend– maps UI range (0‑15) to backend range (0‑255).1.5.toPercent.Testing
Please review the changes and let me know if any further adjustments are needed.