Migration to Swift 6.#133
Open
Aglezabad wants to merge 2 commits into
Open
Conversation
Adaptation of framework to swift 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning:
According to the question asked in issue #132, I've tried to make the migration of Viperit to Swift 6.
Because the module components are coupled to UIViewController and UIViewController is isolated to MainActor, I've also isolated them.
Also, the setUp method for testing Example project has been changed because it's required to use the async variant of setUp (based on the changes made).
After adding those changes, breaking changes are rosen, because all already created Viperit-based modules must be modified and provide compliance to the data isolation of its parent classes (maybe there's a way to provide retro-compatibility and adding a warning but I don't know yet if it's possible).
If anyone can provide some feedback when possible it would be good.
Best regards.