Fix SMB transfer hang: cap TCP burst at 4×MSS#371
Merged
Conversation
felixrieseberg
force-pushed
the
claude/wizardly-elgamal
branch
from
9a51aab to
6cef2e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #370 — the 8×MSS burst overflowed the NE2000 RX ring.
The pump() override sends its whole burst synchronously (the guest CPU doesn't run between
net.receive()calls), so every frame lands in the NE2000 ring before Win95 reads any of them.Dc.prototype.receivesilently discards on overflow, v86 has no retransmit, and the override'shicursor has already advanced past the dropped bytes — Win95 dup-ACKs into the void and the redirector eventually reports "network resource is no longer available".Win95's NE2000 driver gives the RX ring 52–58 pages. 8×MSS (+the loop's one-segment overshoot) plus our preceding ACK is ~10 frames ≈ 60 pages; 4×MSS + ACK is ~36. Dropped the
winsizeclamp too — it's captured once from the SYN and never updated, so it was always 8192 anyway.